Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duplicate folder names in SmartImport wizard #1294 #1297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwin
Copy link

@kwin kwin commented Nov 9, 2023

Only block if new project's description's name is set and already taken. Otherwise the smart import will come up with a new project name prepending the parent folder name followed by "_" (recursively).

Fixes #1294

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Test Results

     900 files  +       1       900 suites  +1   1h 4m 51s ⏱️ + 28m 56s
  7 468 tests ±       0    7 314 ✔️ ±       0  153 💤 ±    0  0  - 1  1 🔥 +1 
23 553 runs  +1 576  23 041 ✔️ +1 454  509 💤 +120  0  - 1  3 🔥 +3 

For more details on these errors, see this check.

Results for commit 4760c84. ± Comparison against base commit 7d88c88.

♻️ This comment has been updated with latest results.

@mickaelistria mickaelistria added this to the 4.31 M1 milestone Dec 4, 2023
@mickaelistria mickaelistria force-pushed the bugfix/duplicate-project-name-in-smartimport-wizard branch 2 times, most recently from efd01bf to c14dd99 Compare December 6, 2023 14:35


Only block if new project's description's name is set and already taken.
Otherwise the smart import will come up with a new project name
prepending the parent folder name followed by "_" (recursively).

Fixes eclipse-platform#1294
@mickaelistria mickaelistria force-pushed the bugfix/duplicate-project-name-in-smartimport-wizard branch from c14dd99 to 4760c84 Compare December 10, 2023 20:37
@mickaelistria
Copy link
Contributor

@mickaelistria mickaelistria removed this from the 4.31 M1 milestone Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate project names handling in SmartImport wizard is broken
2 participants