Allow duplicate folder names in SmartImport wizard #1294 #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
approved these changes
Nov 9, 2023
Test Results 900 files + 1 900 suites +1 1h 4m 51s ⏱️ + 28m 56s For more details on these errors, see this check. Results for commit 4760c84. ± Comparison against base commit 7d88c88. ♻️ This comment has been updated with latest results. |
mickaelistria
force-pushed
the
bugfix/duplicate-project-name-in-smartimport-wizard
branch
2 times, most recently
from
efd01bf
to
c14dd99
Compare
Only block if new project's description's name is set and already taken. Otherwise the smart import will come up with a new project name prepending the parent folder name followed by "_" (recursively). Fixes eclipse-platform#1294
mickaelistria
force-pushed
the
bugfix/duplicate-project-name-in-smartimport-wizard
branch
from
c14dd99
to
4760c84
Compare
|
This PR causes 1 test failure: https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-1297/4/testReport/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only block if new project's description's name is set and already taken. Otherwise the smart import will come up with a new project name prepending the parent folder name followed by "_" (recursively).
Fixes #1294