Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CSS styling of text editors #1349

Closed
wants to merge 1 commit into from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Nov 30, 2023

Migrated the Gerrit from Bug 559321, done by Thomas Wolf.

AbstractTextEditor and subclasses manage their appearance via the editor preferences. If CSS styling is enabled, CSS will override the preferences. So disable CSS styling, and use only the preferences. The CSS engine does set these preferences on theme switches, so the appearance does follow the theme, but now also obeys any preference changes the users makes.

(Note that preference changes get lost on theme switches. But that is unrelated; it appears to be bug 544714.)

Migrated the Gerrit from Bug 559321, done by Thomas Wolf.

AbstractTextEditor and subclasses manage their appearance via the
editor preferences. If CSS styling is enabled, CSS will override
the preferences. So disable CSS styling, and use only the preferences.
The CSS engine does set these preferences on theme switches, so the
appearance does follow the theme, but now also obeys any preference
changes the users makes.

(Note that preference changes get lost on theme switches. But that is
unrelated; it appears to be bug 544714.)

Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
@sratz
Copy link
Member

sratz commented Nov 30, 2023

This is a duplicate of #1036

@vogella vogella closed this Nov 30, 2023
@vogella vogella deleted the disable-css-styling-text-editor branch December 14, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants