Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ErrorDialog AUTOMATED_MODE logging #1697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Feb 19, 2024

tests should not log IllegalStateException when opening ErrorDialog is expected.

eclipse-jdt/eclipse.jdt.debug#395

tests should not log IllegalStateException when opening ErrorDialog is
expected.

eclipse-jdt/eclipse.jdt.debug#395
Copy link
Contributor

Test Results

   917 files   -     1     917 suites   - 1   37m 46s ⏱️ - 7m 58s
 7 434 tests ±    0   7 282 ✅  -     2  150 💤 ±  0  2 ❌ +2 
21 878 runs   - 1 573  21 493 ✅  - 1 456  383 💤  - 119  2 ❌ +2 

For more details on these failures, see this check.

Results for commit ab91e60. ± Comparison against base commit 41d170e.

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception was added on purpose, so one can see which tests are trying to open dialogs - because if they do so, it is in most cases an error and not intended.

So I don't think this PR should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants