Update the static MessageDialog#openQuestion to UX guidelines from the OS #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS Operating system Ui guidelines do not recommend the usage of the help / question icon in a dialog. This change adjusts the MessageDialog#openQuestion accordingly.As this will affect all callers of this method, it has will lead a consistency for callers, users which want / need to violate UX guidelines of the OS can switch to the non static methods or use PlainMessageDialog to construct their dialog in a way which they want. The reasoning for this change is that platform is allowed to adjust its UI to UX changes in the OS and that the UX of Eclipse is not considered API. For example check the screenshots in the Windows guidelines for dialogs. Operating System UI Guidelines Windows UI guidence https://docs.microsoft.com/en-us/windows/apps/design/controls/dialogs-and-flyouts/dialogs Gnome UI guidence https://developer.gnome.org/hig/patterns/feedback/dialogs.html Mac UI guidence https://developer.apple.com/design/human-interface-guidelines/components/presentation/alerts/
laeubi
reviewed
Jun 30, 2022
| @@ -246,7 +247,6 @@ private void init(String dialogTitle, Image dialogTitleImage, String dialogMessa | |||
| case QUESTION: | |||
| case QUESTION_WITH_CANCEL: | |||
| case CONFIRM: { | |||
| this.image = getQuestionImage(); | |||
There was a problem hiding this comment.
Maybe we should leave "CONFIRM" as is and jsut break at QUESTION/WITH_CANCEL? Or even use JFacePreferences to decide if icon should be shown or not?
There was a problem hiding this comment.
I don't see an example for confirmation dialog using a question / help icon in the guidelines https://docs.microsoft.com/en-us/windows/apps/design/controls/dialogs-and-flyouts/dialogs Check for section "Confirmation dialogs (OK/Cancel)".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operating system Ui guidelines do not recommend the usage of the help /
question
icon in a dialog. This change adjusts the MessageDialog#openQuestion
accordingly.As this will affect all callers of this method, it has will
lead a consistency for callers, users which want / need to violate UX
guidelines of the OS can switch to the non static methods or use
PlainMessageDialog to construct their dialog in a way which they want.
The reasoning for this change is that platform is allowed to adjust its
UI to UX changes in the OS and that the UX of Eclipse is not considered
API.
For example check the screenshots in the Windows
guidelines for dialogs.
Operating System UI Guidelines
Windows UI guidence
https://docs.microsoft.com/en-us/windows/apps/design/controls/dialogs-and-flyouts/dialogs
Gnome UI guidence
https://developer.gnome.org/hig/patterns/feedback/dialogs.html
Mac UI guidence
https://developer.apple.com/design/human-interface-guidelines/components/presentation/alerts/