Move specific FindReplaceDialog Tests into the separated test-class #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 812 files + 304 1 812 suites +304 1h 33m 48s ⏱️ + 29m 39s For more details on these failures, see this check. Results for commit 95439d7. ± Comparison against base commit 7372e60. ♻️ This comment has been updated with latest results. |
HeikoKlare
reviewed
May 6, 2024
...kbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceUITest.java
Outdated
Show resolved
Hide resolved
...kbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceUITest.java
Show resolved
Hide resolved
...kbench.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceUITest.java
Outdated
Show resolved
Hide resolved
...ch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_moveDialogTestsToProperClas
branch
from
75460fa
to
47cd1b1
Compare
HeikoKlare
reviewed
May 7, 2024
...ch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/FindReplaceDialogTest.java
Show resolved
Hide resolved
Some tests in FindReplaceUITest.java are not general to all find/replace interfaces and are specific for the find/replace dialog. This commit moves these tests into the dedicated test class and provides the necessary interface in FindReplaceUITest
HeikoKlare
force-pushed
the
MW_moveDialogTestsToProperClas
branch
from
47cd1b1
to
95439d7
Compare
|
Failing test is unrelated and documented: #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in FindReplaceUITest.java are not general to all find/replace interfaces and are specific for the find/replace dialog. This commit moves these tests into the dedicated test class and provides the necessary interface in FindReplaceUITest