Handle the case when application has no focus in ApplicationPartService #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 97cdf28. ♻️ This comment has been updated with latest results. |
fedejeanne
previously requested changes
May 21, 2024
There was a problem hiding this comment.
@laeubi thank you for contributing this. I only have a minor concern regarding the changes in the test class.
NOTE: I only skimmed through the the other changes but I haven't tested them. I could test them do it if you briefly describe how to do it.
....eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/dialogs/UIWorkingSetWizardsAuto.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
handle_case_of_no_focues
branch
from
89047b5
to
e8eeb57
Compare
fedejeanne
dismissed
their stale review
Unrelated changes were moved to another PR
fedejeanne
reviewed
May 21, 2024
|
Sadly the case is quite tricky to test, you need a custom RCP application, you need an external trigger (e.g. Network communication) ... |
Currently when the application has no focus there is also no active window child and in this case several actions still fail even though a part is available for perform actions. This now handles the case of an application without focus with an empty optional to allow fall back to the part context. If that context has still no suitable part service implementation as a last resort the containing window context is used.
laeubi
force-pushed
the
handle_case_of_no_focues
branch
from
e8eeb57
to
97cdf28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the application has no focus there is also no active window child and in this case several actions still fail even though a part is available for perform actions.
This now handles the case of an application without focus with an empty optional to allow fall back to the part context. If that context has still no suitable part service implementation as a last resort the containing window context is used.