[Sticky Scrolling] Fix separator color on windows

[Christopher-Hermann]

The separator in the sticky lines controls are drawn in a bad color on windows dark theme. With this change, the separator color is aligned with the theme.

Current coloring on windows:

How it should look like:

This is a follow up for #1894

[Christopher-Hermann]

@Wittmaxi could you please check if this solves the issue on windows dark theme? If not, I need to set the correct background color for the separator.

[BeckerWdf]

This is a follow up for #1894

You meant point "1" in #1894 (comment) ?

[Christopher-Hermann]

You meant point "1" in #1894 (comment) ?

Yes, correct. Linking the comment is actually a good idea :)

[github-actions]

Test Results

 1 210 files   1 210 suites   53m 22s ⏱️
 7 661 tests  7 431 ✅ 228 💤 2 ❌
16 096 runs  15 625 ✅ 469 💤 2 ❌

For more details on these failures, see this check.

Results for commit fc9981d.

[Wittmaxi]

This is what I see, so no, I Would not consider this a fix. I tried to play around with different color values but I could not find a good fix.
I primarily use dark mode, so I would really appreciate you fixing this :) - thanks for putting in the work!

[Christopher-Hermann]

I tried to play around with different color values but I could not find a good fix.

Could you try to set the color for both separator in StickyLinesControl line 180:
bottomSeparator.setBackground(Display.getDefault().getSystemColor(SWT.COLOR_WIDGET_LIGHT_SHADOW));

[Wittmaxi]

@Christopher-Hermann this is precisely what I tried (well, with another color) - it had no effect on the bars for me.

[Christopher-Hermann]

@Christopher-Hermann this is precisely what I tried (well, with another color) - it had no effect on the bars for me.

Okay, damn you SWT :D Then I need to check on my virtual machine if I can reproduce the error to find a solution.
But it's really strange, I assume that other separators are colored correctly on Windows dark theme.

[Wittmaxi]

@Christopher-Hermann Yes, I have had regular issues with SWT in the past - the dark theme seems to be especially prone to bugs and inconsistencies ;_;