Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore additional parameter #2009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jun 29, 2024

Currently if one passes more parameters as the command accepts (e.g. a parameter was removed from the command), this suddenly leads to commands no longer being found as null is returned.

Instead now ignore additional parameters and simply continue the loop over the map.

Currently if one passes more parameters as the command accepts (e.g. a
parameter was removed from the command), this suddenly leads to commands
no longer being found as null is returned.

Instead now ignore additional parameters and simply continue the loop
over the map.
@iloveeclipse
Copy link
Member

But that would allow commands to start with unexpected number of commands?

Copy link
Contributor

Test Results

 1 210 files   -   605   1 210 suites   - 605   1h 1m 30s ⏱️ - 35m 13s
 7 663 tests ±    0   7 432 ✅  -     3  231 💤 +  3  0 ❌ ±0 
16 100 runs   - 8 050  15 587 ✅  - 7 814  513 💤  - 236  0 ❌ ±0 

Results for commit 99692ac. ± Comparison against base commit 769d5d1.

This pull request skips 3 tests.
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

@laeubi
Copy link
Contributor Author

laeubi commented Jun 29, 2024

But that would allow commands to start with unexpected number of commands?

Can you explain what exactly is meant here? This method constructs a ParameterizedCommand that only contains parameters that are declared by the command, the passed in Map is no longer used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants