Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position find/replace overlay correctly when unmaximizing the window #2017

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Position find/replace overlay correctly when unmaximizing the window #2017

merged 1 commit into from
Jul 4, 2024

Conversation

Wittmaxi
Copy link
Contributor

@Wittmaxi Wittmaxi commented Jul 1, 2024

how to test

  1. maximize window
  2. open overlay
  3. double-click window title (unmaximize)
  4. see that overlay position is still good

@Wittmaxi Wittmaxi mentioned this pull request Jul 1, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 36m 15s ⏱️ + 4m 2s
 7 663 tests ±0   7 435 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 150 runs  ±0  23 401 ✅ +1  749 💤 ±0  0 ❌  - 1 

Results for commit 0b6161e. ± Comparison against base commit a3540d7.

♻️ This comment has been updated with latest results.

@Wittmaxi @HeikoKlare
Find/Replace overlay: improve reaction to windows resizing
0b6161e 
The positioning of the overlay to it's texteditor happens now
asynchronously, improving misunderstandings in positioning.

fixes eclipse-platform#1992
@HeikoKlare HeikoKlare force-pushed the MW_reposition_overlay_on_reducing_window branch from c16001e to 0b6161e Compare July 4, 2024 11:47
HeikoKlare
HeikoKlare approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

@HeikoKlare HeikoKlare merged commit 08d06f9 into eclipse-platform:master Jul 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoKlare HeikoKlare HeikoKlare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wittmaxi @HeikoKlare