Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unminimize Event Details Dialog on update #2020

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

N1k145
Copy link
Contributor

@N1k145 N1k145 commented Jul 1, 2024

Fixes #2019

When the Event Details Dialog is minimized, it is brought back up when the user Double-Clicks a new entry in the Error Log

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Test Results

 1 815 files  +  605   1 815 suites  +605   1h 32m 7s ⏱️ + 31m 48s
 7 663 tests ±    0   7 435 ✅ +    3  228 💤  -   3  0 ❌ ±0 
24 150 runs  +8 050  23 401 ✅ +7 814  749 💤 +236  0 ❌ ±0 

Results for commit 63239e5. ± Comparison against base commit d67d6c7.

♻️ This comment has been updated with latest results.

@N1k145
Copy link
Contributor Author

N1k145 commented Jul 4, 2024

@BeckerWdf thank you for the review.
I don't have permission to merge myself.
Do you want to wait for a second review? If not, you can merge it from my side.

@vogella
Copy link
Contributor

vogella commented Jul 4, 2024

What about the Mac failure?

Fixes eclipse-platform#2019

When the Event Details Dialog is minimized it is brought back up when the user Double Clicks a new entry in the Error Log
@N1k145
Copy link
Contributor Author

N1k145 commented Jul 4, 2024

@vogella looks like this was unrelated as the build now passes

@vogella vogella merged commit 354e1b7 into eclipse-platform:master Jul 4, 2024
16 checks passed
@vogella
Copy link
Contributor

vogella commented Jul 4, 2024

Thanks @N1k145, great to see you continuing to contribute.

Also I see you are a Gloomhaven fan (https://github.com/N1k145/gloomhavensecretariat), great game, shame that the app is based on Electon and not Flutter otherwise I would be very tempted to help with it (and finally finish Jaws of the Lion).

@N1k145
Copy link
Contributor Author

N1k145 commented Jul 4, 2024

@vogella thank you for reviewing and merging.

I have to say that is only my fork, as I contributed some data there. I have no influence on the language or framework ;)
But yes, it is a great game. And sometime I have to continue with Frosthaven :D

@N1k145 N1k145 deleted the issue2019 branch July 4, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the Event Details Dialog is minimized, it is updated in the Background
3 participants