Error after test execution in jenkins/surefire #50 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
force-pushed
the
issue_50
branch
2 times, most recently
from
fff8881
to
7879e18
Compare
…orm#50 Added assertions in runTest() to find out who disposes the display before the test application finishes. Fixed few tests that didn't created Display but disposed it. Note: testingFinished() might or might not run before the display is disposed, because it runs in parallel to the application that closes itself on UI thread after runTest() left syncExec() call. So checking for disposed display in testingFinished() does not make sense. See eclipse-platform#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added assertions to find out who disposes the display before the test
application finishes if it runs in in jenkins/surefire.
Execution in IDE doesn't trigger new assertions.
See #50