-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
random failing RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 #136
Comments
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
In a recent build one can see below results, the test contains the follwoing
so maybe the 20ms are not enough, then the trick would be so somehow know when the actual modification is queued... @HeikoKlare I see you are having some comits referencing this issue, maybe you want to assign the issue to you so it is clear you are working on this?
|
Yes, #413 is a draft for a fix containing the mentioned commits. I will assign the issue to myself, hoping that I find a proper solution. |
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
…rm#136 The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
The test case RelaxedSchedRuleBuilderTest.testBuilderDeltaUsingRelaxedRuleBug343256 performs a workspace change between calling getRule and build when performing a build operation to ensure that build properly considers changes performed in between. To ensure that the job performing a workspace change is scheduled in between executing getRule and build, getRule ends with a sleep to ensure that the workspace-changing job reaches a point where it acquires a lock in between, so it is scheduled before the build operation. Whenever the sleep is not sufficiently long, the test fails. This change makes the getRule operation finish when the workspace-changing job has acquired a lock instead of waiting for a specific amount of time. This ensure that the build operation is always scheduled after the workspace-changing job.
Adjust LaunchConfigurationDelegate.isLaunchProblem(IMarker) to ignore exceptions caused by deleted markers. Fixes: eclipse-platform#136 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Adjusted the exception type caught in LaunchConfigurationDelegate.isLaunchProblem(IMarker), to match the thrown ResourceException. Fixes: eclipse-platform#136 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
https://github.com/eclipse-platform/eclipse.platform/pull/135/checks?check_run_id=8113529011
The text was updated successfully, but these errors were encountered: