Revert "Handle return value 24 the same as 23" #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d074227.
|
Would it harm to keep this and make it more robust? |
Yes, if it's a bug that the 24 surfaced, then it's confusing at best to have downstream code deal with something that should never happen and actually does never happen except during the brief period of time when the bug existed. |
Michael5601
pushed a commit
to CodeLtDave/eclipse.platform
that referenced
this pull request
Feb 12, 2024
…ipse-platform#732)" This reverts commit cfba199.
Michael5601
pushed a commit
to CodeLtDave/eclipse.platform
that referenced
this pull request
Feb 12, 2024
…ipse-platform#732)" This reverts commit cfba199.
laeubi
pushed a commit
to laeubi/eclipse.platform
that referenced
this pull request
Feb 14, 2024
…tform#732) Implement ContentMergeViewer.computeSize and run toolbar updated async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1172
The changes in eclipse-platform/eclipse.platform.ui#1622 avoid this problem.