Don't return null in JobManager::createMonitor #1285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert unintentional change made in 9c3525c and don't return null when creating a progress monitor. This is part of the contract of the method. Contributes to eclipse-platform#664
|
Sorry, this PR doesn't revert anything. Your original PR is already merged o master! |
Shouldn't GH force-push the commit on this PR to replace (amend) the one in #1282 ? |
|
You cannot amend a commit in master. And there is no concept of automatically "replacing one commit with another" either, like the commit in this PR tries to do. If you rebase this commit on master, the commit will simply be removed (as it's then empty) and the the PR will be closed. A reverting PR needs to actively revert changes and not reapply the ones that shall remain in comparison to some other commit. |
|
Replaced by #1286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert unintentional change made in 9c3525c and don't return null when creating a progress monitor. This is part of the contract of the method.
Replaces #1282
Contributes to
#664