Handle updating "Difference/s" label on compare editor for empty toolbar #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iloveeclipse please review the code. |
fedejeanne
reviewed
Apr 17, 2024
...dles/org.eclipse.compare/compare/org/eclipse/compare/contentmergeviewer/TextMergeViewer.java
Outdated
Show resolved
Hide resolved
fedejeanne
force-pushed
the
Bugs/1295_illegalArgumentExceptiom
branch
from
1ab4db3
to
b95364f
Compare
fedejeanne
approved these changes
Apr 17, 2024
Co-authored-by: Federico Jeanne <2205684+fedejeanne@users.noreply.github.com>
fedejeanne
force-pushed
the
Bugs/1295_illegalArgumentExceptiom
branch
from
b95364f
to
710552c
Compare
fedejeanne
added a commit
to fedejeanne/eclipse.platform
that referenced
this pull request
Apr 17, 2024
Follow-up work of eclipse-platform#1319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
illegalArgumentException is handled when toolbar contributions are empty while updating the "Difference/s" label on toolbar of compare editor.
Fixes : #1295