Remove sorting parameter from ConfigurationSessionTestSuite #903 #1356
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latform#903 The ConfigurationSessionTestSuite sorts the test methods by default. A field identifies whether sorting is activated, but the field cannot even be set but is always true. So, this parameterization is completely obsolete and only introduces unnecessary complexity to the session test framework. Contributes to eclipse-platform#903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConfigurationSessionTestSuite sorts the test methods by default. A field identifies whether sorting is activated, but the field cannot even be set but is always true. So, this parameterization is completely obsolete and only introduces unnecessary complexity to the session test framework.
This unnecessary complexity in the JUnit 3 implementation of session tests complicates their migration to JUnit 5. I propose to incrementally remove all unused functionality from the JUnit 3 session test implementation while migrating the actual test classes to the JUnit 5 equivalent and incrementally enhancing the JUnit 5 implementation with what is required. This applies one step of that incremental removal of unused functionality in the JUnit 3 implementation of session tests.
Contributes to #903
❗This removal becomes particularly useful when also #1354 removing shared session support is applied, as in combination even more code can be removed due to conditions becoming empty.