Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows on Arm64 (WoA) build #189

Closed

Conversation

chirontt
Copy link
Contributor

Three new fragments are added to support WoA build:

  • 'org.eclipse.core.filesystem.win32.aarch64': contributing the localfile_1_0_0.dll native library for Arm64. This library was compiled using the natives\win32\arm64\make_arm64.bat file from the 'org.eclipse.core.filesystem' host bundle directory

  • 'org.eclipse.core.net.win32.aarch64'

  • 'org.eclipse.core.resources.win32.aarch64': contributing the win32refresh.dll native library for Arm64. This library was compiled using the natives\make_arm64.bat file from the 'org.eclipse.core.resources' host bundle directory

Three new fragments are added to support WoA build:

- 'org.eclipse.core.filesystem.win32.aarch64': contributing the
localfile_1_0_0.dll native library for Arm64. This library was compiled
using the natives\win32\arm64\make_arm64.bat file from the
'org.eclipse.core.filesystem' host bundle directory

- 'org.eclipse.core.net.win32.aarch64'

- 'org.eclipse.core.resources.win32.aarch64': contributing the
win32refresh.dll native library for Arm64. This library was compiled
using the natives\make_arm64.bat file from the
'org.eclipse.core.resources' host bundle directory
Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not include native win32 aarch fragments in features unless we have a builder in our JIPPs allowing to rebuild them on e.g. source change in filesystem. Until this happens we can only have sources that can't end up in deliverables.

@chirontt
Copy link
Contributor Author

PR withdrawn, as build infrastructure is not yet in place to support building Windows on Arm64 artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants