Port team.ui away of deprecated ResourceSorter #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been announced for removal in 2019 and notification period ended in 2021 so it's high time to get rid of it in 2023. In order to do it proper a good number of places had to be modified from deprecated ViewerSorter to ViewerComparator See https://bugs.eclipse.org/bugs/show_bug.cgi?id=549953 for actual deprecation.
|
I would appreciate second pair of eyes. Soon if possible as without this verification build for the repo fails. |
|
Briefly checked in browser, seem to be OK. |
|
In that case merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been announced for removal in 2019 and notification period ended in 2021 so it's high time to get rid of it in 2023. In order to do it proper a good number of places had to be modified from deprecated ViewerSorter to ViewerComparator
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=549953 for actual deprecation.