Let LocalFile.internalDelete return IStatus instead of boolean #560
+43
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedejeanne
force-pushed
the
275-LocalFile.internalDelete-returns-IStatus
branch
from
0c82f99
to
6f76904
Compare
Test Results 42 files ±0 42 suites ±0 55m 50s ⏱️ +5s For more details on these failures, see this check. Results for commit bbf7392. ± Comparison against base commit 1422671. ♻️ This comment has been updated with latest results. |
This was referenced Jul 4, 2023
HannesWell
reviewed
Jul 14, 2023
...es/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.core.filesystem/src/org/eclipse/core/internal/filesystem/local/LocalFile.java
Outdated
Show resolved
Hide resolved
By returning an IStatus instead of a boolean, the method can better tell callers what went wrong when deleting. The idea is to replace the MultiStatus returned by the "delete" method with a more describing status.
fedejeanne
force-pushed
the
275-LocalFile.internalDelete-returns-IStatus
branch
from
6f76904
to
bbf7392
Compare
|
Thank you @HannesWell for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will help identifying the underlying error that's causing #275 by replacing the vague
MultiStatusreturned byLocalFile::deletewith a more describingIStatuscreated insideinternalDelete.