Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to disable/enable javax-annotation processing for E4-Injector #820

Merged

Conversation

HannesWell
Copy link
Member

The switch can be set via the VM property eclipse.e4.inject.javax.disabled.
For now the default value is 'false', which enables processing of 'javax' annotations by default.

Users can specify the VM argument -Declipse.e4.inject.javax.disabled=true in order to test an application without processing of 'javax' annotations now,

The switch can be set via the VM property
'eclipse.e4.inject.javax.disabled'.
For now the default value is 'false', which enables processing of
'javax' annotations by default.

Users can specify the VM argument
'-Declipse.e4.inject.javax.disabled=true'
in order to test an application without processing of 'javax'
annotations now,
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Test Results

     591 files  ±0       591 suites  ±0   1h 7m 16s ⏱️ - 5m 20s
  3 799 tests ±0    3 794 ✔️ ±0    5 💤 ±0  0 ±0 
12 003 runs  ±0  11 967 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit c61b9ee. ± Comparison against base commit a1c46cd.

@akurtakov
Copy link
Member

I havent' tested the patch but from reading it - it looks good to me.

@HannesWell HannesWell merged commit 312651a into eclipse-platform:master Nov 5, 2023
16 checks passed
@HannesWell HannesWell deleted the javax-processing-switch branch November 5, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants