PKI Implementation #873

JavaJoeS · 2023-11-22T11:28:48Z

PKI integration has been divided into two parts, ui and core for headless systems, as requested. I believe that I have completed all the requests per the review. Testing may be accomplished by creating a .pki file in your .m2 directory, or you can go to org.eclipse.core.pki.util and run the TemplateForPKIfile and it will create a pki.template file for you to fill in per your config.
My recommendation is use PKCS12 for simple testing. PKCS11 requires a vendor implementation such as OpenSC or the like.

JavaJoeS · 2023-11-22T12:56:33Z

Dont forget to remove all of the print statements!

mickaelistria

Before we can consider a review

Please put appropriate license headers to all files
Please squash your commits into a single one. Make sure the commit message describes efficiently the problem that this feature intends to solve
Please describe in the PR a way to test it
Please remove all unused code, commented code and all System.out
Please use org.eclipse.core.net.pki package name
Have you considered providing this support directly in existing org.eclipse.core.net/org.eclipse.ui.net bundles?
If new bundle(s) is necessary, please split those 2 into 1 core and 1 ui bundles; we want security stuff to work even without UI (Eclipse Platform is used without its UI in various cases).

But the most important part is that you didn't yet make clear what problem you're trying to solve that cannot be already solved with proper JVM settings, and how one can verify the problem and the solution. Without it, this code will be forever ignored.

mickaelistria · 2023-11-27T09:00:11Z

team/bundles/org.eclipse.core.pki/META-INF/MANIFEST.MF

+Export-Package: org.eclipse.core.pki,
+ org.eclipse.pki.auth,
+ org.eclipse.pki.dialog,
+ org.eclipse.pki.exception,
+ org.eclipse.pki.interfaces,
+ org.eclipse.pki.jsse,
+ org.eclipse.pki.pkcs,
+ org.eclipse.pki.pkiselection,
+ org.eclipse.pki.preferences,
+ org.eclipse.pki.ui,
+ org.eclipse.pki.util,
+ org.eclipse.pki.wizard,


This list must be shrinked to the bare minimal amount of packages that need to be exported. Ideally, nothing needs to be exported.

OK, gotta figure out what really is needed if anything

mickaelistria · 2023-11-27T09:00:40Z

team/bundles/org.eclipse.core.pki/META-INF/MANIFEST.MF

+Export-Package: org.eclipse.core.pki,
+ org.eclipse.pki.auth,
+ org.eclipse.pki.dialog,
+ org.eclipse.pki.exception,
+ org.eclipse.pki.interfaces,
+ org.eclipse.pki.jsse,
+ org.eclipse.pki.pkcs,
+ org.eclipse.pki.pkiselection,
+ org.eclipse.pki.preferences,
+ org.eclipse.pki.ui,
+ org.eclipse.pki.util,
+ org.eclipse.pki.wizard,
+ target.classes.org.eclipse.core.pki


This line is clearly wrong. The target.classes is not a package, it's a mistake coming from erroneous project configuration.

remove target

ruspl-afed

The majority of files needs license header

ruspl-afed · 2023-11-27T11:57:02Z

team/bundles/org.eclipse.core.pki/META-INF/MANIFEST.MF

+ org.eclipse.equinox.preferences;bundle-version="3.2.200",
+ org.eclipse.osgi;bundle-version="3.4.0",
+ org.eclipse.equinox.registry;bundle-version="3.4.0",
+ org.eclipse.ui;bundle-version="3.203.100",


there should be another bundle with UI part, please do not mix it with "core" part

Any help with this greatly appreciated

ruspl-afed · 2023-11-27T12:00:13Z

team/bundles/org.eclipse.core.pki/META-INF/MANIFEST.MF

+Automatic-Module-Name: org.eclipse.core.pki
+Bundle-ActivationPolicy: lazy
+Bundle-Activator: org.eclipse.pki.auth.AuthenticationPlugin
+Bundle-ClassPath: target/org.eclipse.core.pki-1.0.0.jar,


This could be replaced with
Bundle-ClassPath: .

Yes... will do.

When I remove the target/**.jar, then plugin wont work.. Any suggestions? Im sure its me not being
so familiar with plugins...

ruspl-afed · 2023-11-27T12:00:31Z

team/bundles/org.eclipse.core.pki/plugin.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>


missed license header

Can I grab a header off file already in a bundle, copy and paste to all files needing header????

ruspl-afed · 2023-11-27T12:00:57Z

team/bundles/org.eclipse.core.pki/plugin.xml

+			category="org.eclipse.ui.net.NetPreferences"
+            class="org.eclipse.pki.preferences.PreferencePage"
+            id="org.eclipse.preferences.pkcs"
+            name="Java KeyStore Setup">


missed i18n

Where does that go? on the name portion?

Tried to find another plugin.xml file so I could see where the i18n is supposed to be... None that I looked at had it??

ruspl-afed · 2023-11-27T12:03:08Z

team/bundles/org.eclipse.core.pki/src/org/eclipse/pki/auth/AuthenticationPlugin.java

+/**
+ * The activator class controls the plug-in life cycle
+ */
+public class AuthenticationPlugin extends AbstractUIPlugin {


this one should be split to core and ui part

Agree ton of work needed here.

ruspl-afed · 2023-11-27T12:04:34Z

team/bundles/org.eclipse.core.pki/src/org/eclipse/pki/auth/AuthenticationPlugin.java

+    // The shared instance
+    private static AuthenticationPlugin plugin;
+
+    protected static final String DEFAULT_TRUST_STORE = "cacerts";


not clear why one would need protected constants for Activator. I hope there is no plan to inherit from this type.

ruspl-afed · 2023-11-27T12:09:10Z

team/bundles/org.eclipse.core.pki/src/org/eclipse/pki/auth/AuthenticationPlugin.java

+    public static AuthenticationPlugin getDefault() {
+    	System.out.println("AuthenticationPlugin ---getDefault plugin");
+    	if (plugin == null) {
+    		AuthenticationPlugin auth = new AuthenticationPlugin();


Do you plan to support running without Platform for your plug-in? In this case I would consider another functionality entry point instead.
Moreover, activator should be an internal type that implements hooks for Bundle lifecycle. Ideally activator should not be present at all to avoid startup impact.

Very good question.. I think the answer should be YES. Support with or without GUI. The gotcha on this is
having all the required setup, more so for PKCS11 implementation..

JavaJoeS · 2023-11-29T11:08:21Z

In a nutshell, today's internet is tons of URLs which almost all are HTTPS single authentication sites. They are secured by X509 Certificates that (mostly) have been secured via public Certificate Authorities. They are single, basic authentication since we all use some browser or other that has the Certificate Authority already added in, or via a Java JDK where they are also embedded. HOWEVER, more and more companies, private entities, even some gubmints are creating internet sites with URLs that require two way authentication requiring YOU to have your own x509 Certificate in a Key Store signed by Their Certificate Authority. Eclipse DOES not contain this capability. The PKI Implementation I am trying to add, will provide this capability.

Reduces compiler warnings in workspace and I-build reports.

Fixes the architecture link to the Eclipse wiki.

JavaJoeS · 2024-01-23T19:29:27Z

Where is the best place to write docs to describe usage/testing? I use my account from Amazon AWS to do lots of coding.
account email is different? Do I need an additional ECA for that account too?

UPDATE: I changed author/committer to same as my ECA.. Used git filter just like a pro JOE... lol

….git

JavaJoeS · 2024-01-25T09:30:02Z

I believe I have satisfied all the requests/modifications.

mickaelistria requested changes Nov 27, 2023

View reviewed changes

ruspl-afed requested changes Nov 27, 2023

View reviewed changes

jjschia and others added 26 commits January 2, 2024 10:05

Add initialized store and trust

2a25d3b

Checking PKI for ui

ecf8440

Checking PKI for ui

981ede6

Update property version

c214e5d

Update property version

bbf74f8

Remove unused

9d840e3

Remove unused

4624ffc

Update versions in required plugins

faa6be6

Update versions in required plugins

c3241fd

Update parameters from ini file

c97246c

Update parameters from ini file

3afe797

Add default sslcontext

3311985

Add default sslcontext

24a4f1d

Update PKI state index

236dcf4

Update PKI state index

7732679

Check command line pki

265d3a4

Check command line pki

762f13f

Fix encrypted passwd check

40ea543

Fix encrypted passwd check

c710910

test decrypt flag

4eb5703

test decrypt flag

578782d

Add property value

9babb06

Add property value

bd5aee4

Various warning fixes in debug examples

da3231c

Reduces compiler warnings in workspace and I-build reports.

Test decrypt value

0cbe1fe

Test decrypt value

11ff87a

vogella and others added 14 commits January 23, 2024 12:02

Fixes link in API Deprecation policy

58385d2

Fixes the architecture link to the Eclipse wiki.

RefreshLocalJavaFileBuilder: use java.nio

b3dd9dc

remove system out debug

f640d6c

remove system out debug

e7e3f65

Merge branch 'master' of git@github.com:JavaJoeS/eclipse.platform.git

721824c

Merge branch 'master' of git@github.com:JavaJoeS/eclipse.platform.git

3334511

Remove system out debug and provider

04dfe9f

Remove system out debug and provider

6344674

remove system out debug

9f2706a

remove system out debug

a6c7525

Remove system out debug

f59c627

Remove system out debug

8a438db

Merge branch 'eclipse-platform:master' into master

b98f93c

Merge branch 'eclipse-platform:master' into master

ac16346

JavaJoeS marked this pull request as ready for review January 23, 2024 15:24

jjschia and others added 5 commits January 24, 2024 11:19

Create a template for pki file

8cbc0fd

Removing system.out debug

ead81d5

Move to branch

9441823

Merge branch 'master' of https://github.com/JavaJoeS/eclipse.platform…

c01eff1

….git

Merge branch 'master' into master

5da75c4

JavaJoeS closed this Jan 25, 2024

JavaJoeS reopened this Jan 25, 2024

Merge branch 'master' into master

ab06a4d

JavaJoeS requested review from mickaelistria and ruspl-afed January 25, 2024 10:00

jjschia and others added 2 commits January 25, 2024 12:46

Merge branch 'master' of git@github.com:JavaJoeS/eclipse.platform.git

2becef8

Merge branch 'master' into master

09f9e49

JavaJoeS closed this Jan 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PKI Implementation #873

PKI Implementation #873

JavaJoeS commented Nov 22, 2023 •

edited

JavaJoeS commented Nov 22, 2023

mickaelistria left a comment

mickaelistria Nov 27, 2023

JavaJoeS Nov 28, 2023

mickaelistria Nov 27, 2023

JavaJoeS Nov 28, 2023

ruspl-afed left a comment

ruspl-afed Nov 27, 2023

JavaJoeS Nov 28, 2023

ruspl-afed Nov 27, 2023

JavaJoeS Nov 28, 2023

JavaJoeS Nov 28, 2023

ruspl-afed Nov 27, 2023

JavaJoeS Nov 28, 2023

ruspl-afed Nov 27, 2023

JavaJoeS Nov 28, 2023

JavaJoeS Nov 28, 2023

ruspl-afed Nov 27, 2023

JavaJoeS Nov 28, 2023

ruspl-afed Nov 27, 2023

ruspl-afed Nov 27, 2023

JavaJoeS Nov 28, 2023

JavaJoeS commented Nov 29, 2023

JavaJoeS commented Jan 23, 2024 •

edited

JavaJoeS commented Jan 25, 2024

PKI Implementation #873

PKI Implementation #873

Conversation

JavaJoeS commented Nov 22, 2023 • edited

JavaJoeS commented Nov 22, 2023

mickaelistria left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ruspl-afed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JavaJoeS commented Nov 29, 2023

JavaJoeS commented Jan 23, 2024 • edited

JavaJoeS commented Jan 25, 2024

JavaJoeS commented Nov 22, 2023 •

edited

JavaJoeS commented Jan 23, 2024 •

edited