Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add N&N for PDE Bundle/Version Annotations #47

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Add N&N for PDE Bundle/Version Annotations #47

merged 1 commit into from
Aug 8, 2022

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jul 24, 2022

No description provided.

@akurtakov akurtakov merged commit d8dbbf6 into eclipse-platform:master Aug 8, 2022
iloveeclipse pushed a commit to iloveeclipse/www.eclipse.org-eclipse-news that referenced this pull request Aug 15, 2022
@jjohnstn @carstenartur @sravanlakkimsetti
Carstenartur/master (eclipse-platform#22)
a7851c1 
* Bug <tbd> - add N&N Entry for System property extension

Add short entry to show variants supported by system property extension.
Now supporting long and integer and boolean variant with default value.

Change-Id: I98b8af75f4dcc8859264de4f44f4e916854a788b
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>

* Create codeql-analysis.yml

* Revert "Create codeql-analysis.yml"

This reverts commit 8c165f6.

* Modify N&N

- fixes eclipse-platform#47

Co-authored-by: Carsten Hammer <carsten.hammer@t-online.de>
Co-authored-by: Sravan Kumar Lakkimsetti <77106773+sravanlakkimsetti@users.noreply.github.com>
@SarikaSinha
Copy link
Member

@laeubi
Can you please provide the github issue or bugzilla link in the N&N entry ?
instructions.html has the instructions to include them.
Not able to understand, how to edit the target platform as an editor ? Can you please explain.

@vik-chand

@vik-chand
Copy link
Member

@laeubi Can you please provide the github issue or bugzilla link in the N&N entry ? instructions.html has the instructions to include them. Not able to understand, how to edit the target platform as an editor ? Can you please explain.

@vik-chand

If we are not able to understand this, then we will have to remove it from PDE N&N. Please provide steps/instructions by Wednesday ( 24th Aug).

@laeubi
Copy link
Contributor Author

laeubi commented Aug 23, 2022

Issue is eclipse-pde/eclipse.pde#69 / PR

Not able to understand, how to edit the target platform as an editor ? Can you please explain.

Explain what? Target Platform editor is not part of this change.

@SarikaSinha
Copy link
Member

N&N should explain how this target platform editor can be accessed.

@laeubi
Copy link
Contributor Author

laeubi commented Aug 23, 2022

N&N should explain how this target platform editor can be accessed.

As mentioned this has nothing to do with target platform editor ... The target snippet is just an example and you could of course add it by other means, and I assume any PDE developer is familiar how to configure its target?

@vik-chand
Copy link
Member

vik-chand commented Aug 25, 2022 •
edited
Loading

N&N should explain how this target platform editor can be accessed.

As mentioned this has nothing to do with target platform editor ... The target snippet is just an example and you could of course add it by other means, and I assume any PDE developer is familiar how to configure its target?

I think we can remove that part which is just plain confusing. ( at best we can mention at the end of the N&N entry that for older projects one need to configure target so as to add those bundles) . Morever in a new plugin project those 2 bundles are available by default. Rest of the N&N looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse Awaiting requested review from iloveeclipse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laeubi @SarikaSinha @vik-chand @akurtakov