CoreException due to deprecated extension points

[ghost]

Hello everyone, we use the filesystem project in our application in order to create Eclipse projects that only exist in-memory, rather than on the file system.

However, some of the UI contributions no longer seem to work on newer Eclipse versions and fail with an exception when, e.g. right-clicking on an object in our project explorer:

org.eclipse.core.runtime.CoreException: Unknown expression element objectState > or > enablement > objectContribution (id=org.eclipse.ui.examples.filesystem.contribution1) : org.eclipse.ui.popupMenus @ org.eclipse.ui.examples.filesystem
at org.eclipse.core.expressions.ExpressionConverter.processChildren(ExpressionConverter.java:128)
at org.eclipse.core.expressions.ElementHandler.processChildren(ElementHandler.java:104)
at org.eclipse.core.internal.expressions.StandardElementHandler.create(StandardElementHandler.java:34)
at org.eclipse.core.expressions.ExpressionConverter.perform(ExpressionConverter.java:90)
at org.eclipse.core.expressions.ExpressionConverter.processChildren(ExpressionConverter.java:126)
at org.eclipse.core.expressions.ElementHandler.processChildren(ElementHandler.java:104)
at org.eclipse.core.internal.expressions.StandardElementHandler.create(StandardElementHandler.java:64)
at org.eclipse.core.expressions.ExpressionConverter.perform(ExpressionConverter.java:90)
...

[ghost]

I also think this is a really useful functionality. Maybe it would be an option to make this into a standard feature of the Eclipse?

[mickaelistria]

Can these examples be fixed by improving the enablement expression instead of just removing them?

[vogella]

Wouldn't it be better to fix the core expression? How can you use the example without the pop-up menus?

[ghost]

Can these examples be fixed by improving the enablement expression instead of just removing them?

I have fixed the example. It seems like the enablement block only had to be moved into the action block.

At least that's the first step. Next I'd like to migrate the example project away from the 'org.eclipse.ui.popupMenus' extension point.

There are also some parts of the code I'd like to clean up (e.g. raw types, missing annotations etc.), but I'll create a separate pull request for those.

[vogella]

Thanks @pzi-dsa

As discussed I think we should move this project out of the website and into the https://github.com/eclipse-platform/eclipse.platform.resources project into a new examples folder so that it gets actually compiiled and people can find it as this is a really nice example of the EFS usage.

Would you be interested in providing a PR for resource to move the project to the new repo? If yes please do so and afterwards send the additional improvements so that the changes will be validated via the resource validation build.