Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build configuration for RAP Runtime 3.22.0 M1 #34

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

mknauer
Copy link
Contributor

@mknauer mknauer commented Jul 8, 2022

Update build configuration for RAP Runtime 3.22.0 M1

  • Use Eclipse Platform 4.25 I20220706-1800 (M1)
  • Use Eclipse Orbit 2022-09
  • Use Eclipse Jetty 10.0.11

Also removes the version constraint from the import of the Java package
com.ibm.icu.text in the org.eclipse.e4.ui.workbench and
org.eclipse.e4.ui.workbench.swt bundle because there is no bundle
exporting the package with version any more.

Update the lower boundary of javax.servlet package imports in the
org.eclipse.rap.rwt.osgi bundle to at least 4.0.0 in order to ensure
that no lower, incompatible servlet version is imported which leads to
compile errors.

- Use Eclipse Platform 4.25 I20220706-1800 (M1)
- Use Eclipse Orbit 2022-09
- Use Eclipse Jetty 10.0.11

Also removes the version constraint from the import of the Java package
`com.ibm.icu.text` in the `org.eclipse.e4.ui.workbench` and
`org.eclipse.e4.ui.workbench.swt` bundle because there is no bundle
exporting the package *with* version any more.

Update the lower boundary of javax.servlet package imports in the
`org.eclipse.rap.rwt.osgi` bundle to at least 4.0.0 in order to ensure
that no lower, incompatible servlet version is imported which leads to
compile errors.

Change to javax.servlet 4.0 up to 5.0
@mknauer mknauer added the releng Release engineering tasks label Jul 8, 2022
@mknauer mknauer requested a review from ifurnadjiev July 8, 2022 19:12
@mknauer mknauer self-assigned this Jul 8, 2022
@mknauer
Copy link
Contributor Author

mknauer commented Jul 8, 2022

This commit needs a bit more work as it doesn't compile yet... there are some new methods in upstream classes/interfaces:
(Correction: Actually they are not new, they are not yet existent because the build suddenly seems to consume an older version without the new methods.)

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:2.1.0:compile (default-compile) on project org.eclipse.rap.rwt.osgi: Compilation failure: Compilation failure: 
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[351] 
[ERROR] 	public Dynamic addJspFile( String servletName, String jspFile ) {
[ERROR] 	               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method addJspFile(String, String) of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[356] 
[ERROR] 	public int getSessionTimeout() {
[ERROR] 	           ^^^^^^^^^^^^^^^^^^^
[ERROR] The method getSessionTimeout() of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[357] 
[ERROR] 	return servletContext.getSessionTimeout();
[ERROR] 	                      ^^^^^^^^^^^^^^^^^
[ERROR] The method getSessionTimeout() is undefined for the type ServletContext
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[361] 
[ERROR] 	public void setSessionTimeout( int sessionTimeout ) {
[ERROR] 	            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method setSessionTimeout(int) of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[362] 
[ERROR] 	servletContext.setSessionTimeout( sessionTimeout );
[ERROR] 	               ^^^^^^^^^^^^^^^^^
[ERROR] The method setSessionTimeout(int) is undefined for the type ServletContext
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[366] 
[ERROR] 	public String getRequestCharacterEncoding() {
[ERROR] 	              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getRequestCharacterEncoding() of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[367] 
[ERROR] 	return servletContext.getRequestCharacterEncoding();
[ERROR] 	                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getRequestCharacterEncoding() is undefined for the type ServletContext
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[371] 
[ERROR] 	public void setRequestCharacterEncoding( String encoding ) {
[ERROR] 	            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method setRequestCharacterEncoding(String) of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[372] 
[ERROR] 	servletContext.setRequestCharacterEncoding( encoding );
[ERROR] 	               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method setRequestCharacterEncoding(String) is undefined for the type ServletContext
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[376] 
[ERROR] 	public String getResponseCharacterEncoding() {
[ERROR] 	              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getResponseCharacterEncoding() of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[377] 
[ERROR] 	return servletContext.getResponseCharacterEncoding();
[ERROR] 	                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method getResponseCharacterEncoding() is undefined for the type ServletContext
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[381] 
[ERROR] 	public void setResponseCharacterEncoding( String encoding ) {
[ERROR] 	            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method setResponseCharacterEncoding(String) of type ServletContextWrapper must override or implement a supertype method
[ERROR] .../projects/rap/org.eclipse.rap/bundles/org.eclipse.rap.rwt.osgi/src/org/eclipse/rap/rwt/osgi/internal/ServletContextWrapper.java:[382] 
[ERROR] 	servletContext.setResponseCharacterEncoding( encoding );
[ERROR] 	               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The method setResponseCharacterEncoding(String) is undefined for the type ServletContext

@mknauer mknauer marked this pull request as draft July 8, 2022 19:15
@mknauer
Copy link
Contributor Author

mknauer commented Jul 10, 2022

I was able to fix the above error by setting the lower boundary of the javax.servlet import to be at least 4.0.0 in our org.eclipse.rap.rwt.osgi bundle. This seems to pass the higher version import to the compiler, and omits the one that doesn't provide the new methods that require implementations/overrides.

@ifurnadjiev ifurnadjiev marked this pull request as ready for review July 11, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releng Release engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants