Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test server implementations #3507

Open
abrokenjester opened this issue Dec 11, 2021 · 4 comments
Open

Clean up test server implementations #3507

abrokenjester opened this issue Dec 11, 2021 · 4 comments
Labels
🔧 internal task a project workflow / setup task not directly impacting end users 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks

Comments

@abrokenjester
Copy link
Contributor

The test rig currently has at least four separate implementations of a Jetty-based test server:

  • org.eclipse.rdf4j.http.server.TestServer (in rdf4j-http-server unit tests)
  • org.eclipse.rdf4j.repository.http.HTTPMemServer (in rdf4j-repository-compliance)
  • org.eclipse.rdf4j.query.parser.sparql.SPARQLEmbeddedServer (in rdf4j-sparql-compliance)
  • org.eclipse.rdf4j.federated.server.SPARQLEmbeddedServer (in rdf4j-tools-federation)

All four do essentially the same thing: spin up an RDF4J Server on localhost with a few test repositories to run tests over HTTP against. We should unify these into a single reusable test utility.

@abrokenjester abrokenjester added 🔧 internal task a project workflow / setup task not directly impacting end users 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks labels Dec 11, 2021
@github-actions github-actions bot added this to 📥 Inbox in Project Progress Dec 11, 2021
@abrokenjester abrokenjester moved this from 📥 Inbox to 📋 Backlog in Project Progress Dec 11, 2021
@barthanssens
Copy link
Contributor

Seems to be duplicate of #2933

@abrokenjester
Copy link
Contributor Author

Seems to be duplicate of #2933

Oops! So it is, well spotted. The description on this issue is more up to date so I'll close the other one.

@erikgb
Copy link
Contributor

erikgb commented Feb 16, 2023

@abrokenjester @barthanssens WDYT about adopting something like https://mjeanroy.dev/junit-servers/ instead of building our own test utility? I did a small POC, and seems to work well.

@erikgb
Copy link
Contributor

erikgb commented Feb 17, 2023

Here is an MVP POC showing how this could look like: #4437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 internal task a project workflow / setup task not directly impacting end users 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
No open projects
Project Progress
📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants