Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid transitive dependency management in modules using test server #4474

Closed
erikgb opened this issue Mar 3, 2023 · 0 comments · Fixed by #4475
Closed

Avoid transitive dependency management in modules using test server #4474

erikgb opened this issue Mar 3, 2023 · 0 comments · Fixed by #4475
Assignees
@erikgb
Labels
📶 enhancement issue is a new feature or improvement
Milestone
4.3.0

Comments

@erikgb
Copy link
Contributor

erikgb commented Mar 3, 2023

Problem description

While working on #4464, I noticed that the two compliance modules that currently use a test server explicitly manage transitive dependencies (from rdf4j-http-server module). This is far from optimal and should be improved, and is also a semi-blocker for doing improvements to the test server duplication, ref. #3507.

Preferred solution

I suggest to publish a "classes" attachment from the rdf4j-http-server that can be used to avoid this duplication of dependency management.

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

No response
@erikgb erikgb added the 📶 enhancement issue is a new feature or improvement label Mar 3, 2023
erikgb added a commit to erikgb/rdf4j that referenced this issue Mar 3, 2023
@erikgb
eclipse-rdf4jGH-4474: Publish classes attachment from war modules
e5f8241 
By publishing classes artifacts from war modules we avoid the duplicated dependency management in modules using the war to run tests with a test server.
@erikgb erikgb mentioned this issue Mar 3, 2023
Merged
5 tasks
erikgb added a commit to erikgb/rdf4j that referenced this issue Mar 3, 2023
@erikgb
eclipse-rdf4jGH-4474: Publish classes attachment from war modules
4891c98 
By publishing classes artifacts from war modules we avoid the duplicated dependency management in modules using the war to run tests with a test server.
@erikgb erikgb changed the title Avoid management of transitive dependencies in modules with test server Avoid transitive dependency management in modules using test server Mar 3, 2023
erikgb added a commit to erikgb/rdf4j that referenced this issue Mar 5, 2023
@erikgb
eclipse-rdf4jGH-4474: Publish classes attachment from war modules
756facb 
By publishing classes artifacts from war modules we avoid the duplicated dependency management in modules using the war to run tests with a test server.
@abrokenjester abrokenjester linked a pull request Mar 17, 2023 that will close this issue
GH-4474: Publish classes attachment from war modules #4475
Merged
5 tasks
@abrokenjester abrokenjester added this to the 4.3.0 milestone Mar 17, 2023
erikgb added a commit to erikgb/rdf4j that referenced this issue Mar 20, 2023
@erikgb
eclipse-rdf4jGH-4474: Publish classes attachment from war modules
2c2ced1
abrokenjester added a commit that referenced this issue Apr 10, 2023
@abrokenjester
GH-4474: Publish classes attachment from war modules (#4475)
be4bcd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgb erikgb

Labels
📶 enhancement issue is a new feature or improvement
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

GH-4474: Publish classes attachment from war modules erikgb/rdf4j
2 participants
@abrokenjester @erikgb