Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace commons-fileupload with servlet 3.0 multipart support #4378

Closed
abrokenjester opened this issue Jan 19, 2023 Discussed in #4370 · 1 comment · Fixed by #4375
Closed

Replace commons-fileupload with servlet 3.0 multipart support #4378

abrokenjester opened this issue Jan 19, 2023 Discussed in #4370 · 1 comment · Fixed by #4375
Labels
duplicate issue is a duplicate (close reason) 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks

Comments

@abrokenjester
Copy link
Contributor

Discussed in #4370

Originally posted by erikgb January 18, 2023
I am looking at #3559, as it represents a total blocker for upgrading spring/spring-boot for us in a project that also has dependencies to rdf4j. This is assumed a significant task, so it has to be divided into parts. And I hope some of it can be done pre-migrating javax -> jakarta.

One blocker I have identified is the dependency we have to commons-fileupload (in rdf4j-http-workbench). commons-fileupload does not have any new releases since 2018, and it should not really be required - as servlet 3.0 added support for in-tree multipart handling: https://docs.oracle.com/javaee/7/tutorial/servlets011.htm

Do you think this is doable? I don't see how I could do this effectively - without some knowledge of how the rdf4j-http-workbench fits in the overall rdf4j ecosystem, and would at least require some input from maintainers!

@abrokenjester abrokenjester linked a pull request Jan 19, 2023 that will close this issue
5 tasks
@abrokenjester abrokenjester added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label Jan 19, 2023
@abrokenjester abrokenjester added this to the 4.2.3 milestone Jan 19, 2023
@abrokenjester abrokenjester added the duplicate issue is a duplicate (close reason) label Jan 19, 2023
@abrokenjester
Copy link
Contributor Author

Didn't realise you had already created an issue: #4374. Closing this as a duplicate

@abrokenjester abrokenjester removed this from the 4.2.3 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate issue is a duplicate (close reason) 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant