Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate all dependencies to commons-fileupload #4374

Closed
erikgb opened this issue Jan 18, 2023 · 0 comments · Fixed by #4375
Closed

Eliminate all dependencies to commons-fileupload #4374

erikgb opened this issue Jan 18, 2023 · 0 comments · Fixed by #4375
Assignees
@erikgb
Labels
🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Milestone
4.3.0

Comments

@erikgb
Copy link
Contributor

erikgb commented Jan 18, 2023

Problem description

commons-fileupload hasn't had any release since 2018, and is not really required - as Java EE added support for multipart handling in Servlet 3.0, ref. https://docs.oracle.com/javaee/7/tutorial/servlets011.htm.

Removing the dependency to commons-fileupload is a pre-requirement to the javax -> jakarta migration proposed in #3559.

Preferred solution

Replace the current multipart request handling supported by commons-fileupload with Servlet 3.0 multipart.

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

No response

Anything else?

No response
@erikgb erikgb added the 📶 enhancement issue is a new feature or improvement label Jan 18, 2023
erikgb added a commit to erikgb/rdf4j that referenced this issue Jan 18, 2023
@erikgb
eclipse-rdf4jGH-4374 Eliminate commons-fileupload dependencies
1d1bb8d
@erikgb erikgb mentioned this issue Jan 18, 2023
Merged
5 tasks
erikgb added a commit to erikgb/rdf4j that referenced this issue Jan 18, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
b4608fe
@abrokenjester abrokenjester mentioned this issue Jan 19, 2023
Closed
@abrokenjester abrokenjester added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label Jan 19, 2023
@abrokenjester abrokenjester added this to the 4.2.3 milestone Jan 19, 2023
@abrokenjester abrokenjester removed the 📶 enhancement issue is a new feature or improvement label Jan 19, 2023
erikgb added a commit to erikgb/rdf4j that referenced this issue Jan 20, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
4699e98
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 5, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
2e9a29f
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 5, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
894b01e
@hmottestad hmottestad modified the milestones: 4.2.3, 4.2.4 Feb 11, 2023
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 13, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
c89c620
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 16, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
9a8b9a7
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 20, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
c77668b
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 25, 2023
@erikgb
eclipse-rdf4jGH-4374 eliminate commons-fileupload dependencies
8c72872
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 25, 2023
@erikgb
eclipse-rdf4jGH-4374: Eliminate commons-fileupload dependency
19c7f3c
abrokenjester added a commit that referenced this issue Mar 4, 2023
@abrokenjester
GH-4374: Eliminate commons-fileupload dependency (#4375)
0e920e2
@abrokenjester abrokenjester modified the milestones: 4.2.4, 4.3.0 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgb erikgb

Labels
🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

GH-4374: Eliminate commons-fileupload dependency erikgb/rdf4j
3 participants
@abrokenjester @hmottestad @erikgb