Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changeset: approvedEmpty and deprecatedEmpty should always be false at particular point #4554

Open
kenwenzel opened this issue May 16, 2023 · 0 comments
Open

Changeset: approvedEmpty and deprecatedEmpty should always be false at particular point #4554

kenwenzel opened this issue May 16, 2023 · 0 comments
Assignees
@kenwenzel
Labels
🐞 bug issue is a bug ⏩ performance

Comments

@kenwenzel
Copy link
Contributor

kenwenzel commented May 16, 2023 •
edited
Loading

Current Behavior

Changeset uses this

https://github.com/eclipse/rdf4j/blob/39a07105167201124c75bb9decc9749a143cc7e7/core/sail/base/src/main/java/org/eclipse/rdf4j/sail/base/Changeset.java#L419

and this

https://github.com/eclipse/rdf4j/blob/39a07105167201124c75bb9decc9749a143cc7e7/core/sail/base/src/main/java/org/eclipse/rdf4j/sail/base/Changeset.java#L450

code to update the flags approvedEmpty and deprecatedEmpty
resulting in a contains(...) call based on the code in AbstractModel:

https://github.com/eclipse/rdf4j/blob/39a07105167201124c75bb9decc9749a143cc7e7/core/model/src/main/java/org/eclipse/rdf4j/model/impl/AbstractModel.java#L47

Expected Behavior

At these points the sets should always be non-empty and hence the flags could be initialized to false.

Steps To Reproduce

No response

Version

4.3.0-M2

Are you interested in contributing a solution yourself?

Perhaps?

Anything else?

No response
@kenwenzel kenwenzel added the 🐞 bug issue is a bug label May 16, 2023
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 17, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fixed performance of Changeset in combination wi…
e7ab299 
…th MemoryOverflowModel

Increase the performance for large transactions requiring overflow to disk
for NativeStore and LmdbStore.
@kenwenzel kenwenzel mentioned this issue May 17, 2023
Open
5 tasks
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 17, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fixed performance of Changeset in combination wi…
8603d3e 
…th MemoryOverflowModel

Increase the performance for large transactions requiring overflow to disk
for NativeStore and LmdbStore.
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 17, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fixed performance of Changeset in combination wi…
2b721c2 
…th MemoryOverflowModel

Increase the performance for large transactions requiring overflow to disk
for NativeStore and LmdbStore.
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 17, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Improve logic for deciding on disk overflow.
9863514
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 17, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Close models without relying on finalize.
929f908
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 23, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fix performance of memory overflow
4f67b34 
- do not verify additions in Changeset via isEmpty()
- proactively close MemoryOverflowModel in Changeset by using AutoClosable interface
- use GarbageCollectorMXBean to monitor GC load
- do not isolate transactions in LmdbStore when used in MemoryOverflowModel
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 23, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fix performance of memory overflow
5b896ad 
- do not verify additions in Changeset via isEmpty()
- proactively close MemoryOverflowModel in Changeset by using AutoClosable interface
- use GarbageCollectorMXBean to monitor GC load
- do not isolate transactions in LmdbStore when used in MemoryOverflowModel
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 23, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fix performance of memory overflow
d477015 
- do not verify additions in Changeset via isEmpty()
- proactively close MemoryOverflowModel in Changeset by using AutoClosable interface
- use GarbageCollectorMXBean to monitor GC load
- do not isolate transactions in LmdbStore when used in MemoryOverflowModel
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 23, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fix performance of memory overflow
545d38a 
- do not verify additions in Changeset via isEmpty()
- proactively close MemoryOverflowModel in Changeset by using AutoClosable interface
- use GarbageCollectorMXBean to monitor GC load
- do not isolate transactions in LmdbStore when used in MemoryOverflowModel
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 24, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Fix performance of memory overflow
e9dac06 
- do not verify additions in Changeset via isEmpty()
- proactively close MemoryOverflowModel in Changeset by using AutoClosable interface
- use GarbageCollectorMXBean to monitor GC load
- do not isolate transactions in LmdbStore when used in MemoryOverflowModel
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 24, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Correctly close changesets
2d5f307 
- some shallow copies of Changeset were not closed at all
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 24, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Correctly close changesets
cc63c42 
- some shallow copies of Changeset were not closed at all
- use reference counting for approved and deprecated models
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 24, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Correctly close changesets
eda84e4 
- some shallow copies of Changeset were not closed at all
- use reference counting for approved and deprecated models
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 24, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Correctly close changesets
ec1bd49 
- some shallow copies of Changeset were not closed at all
- use reference counting for approved and deprecated models
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 25, 2023
@kenwenzel
eclipse-rdf4jGH-4554 Allow removeRefBack() on already closed changesets
2cdcd7a
@hmottestad hmottestad mentioned this issue Aug 5, 2023
Closed
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 20, 2024
@kenwenzel
eclipse-rdf4jGH-4554 Fix performance of memory overflow
f4d21b2 
- do not verify additions in Changeset via isEmpty()
- proactively close MemoryOverflowModel in Changeset by using AutoClosable interface
- use GarbageCollectorMXBean to monitor GC load
- do not isolate transactions in LmdbStore when used in MemoryOverflowModel

# Conflicts:
#	core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/LmdbStore.java
#	core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/MemoryOverflowModel.java
#	core/sail/lmdb/src/main/java/org/eclipse/rdf4j/sail/lmdb/SailSourceModel.java
#	core/sail/nativerdf/src/main/java/org/eclipse/rdf4j/sail/nativerdf/MemoryOverflowModel.java
#	core/sail/nativerdf/src/main/java/org/eclipse/rdf4j/sail/nativerdf/SailSourceModel.java
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 20, 2024
@kenwenzel
eclipse-rdf4jGH-4554 Correctly close changesets
a4f360d 
- some shallow copies of Changeset were not closed at all
- use reference counting for approved and deprecated models
kenwenzel added a commit to kenwenzel/rdf4j that referenced this issue May 20, 2024
@kenwenzel
eclipse-rdf4jGH-4554 Allow removeRefBack() on already closed changesets
5610e2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenwenzel kenwenzel

Labels
🐞 bug issue is a bug ⏩ performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenwenzel @hmottestad