Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove my own design errors with v5 #4581

Closed
JervenBolleman opened this issue May 21, 2023 · 0 comments · Fixed by #4582
Closed

Remove my own design errors with v5 #4581

JervenBolleman opened this issue May 21, 2023 · 0 comments · Fixed by #4582
Assignees
@JervenBolleman
Labels
M3 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Milestone
5.0.0

Comments

@JervenBolleman
Copy link
Contributor

Current Behavior

There are a few errors in design that are already deprecated but where originally introduced my myself. With the wisdom of a few years more I would like to remove them.
Chief among them are the LimitedSize strategy, and makeSet methods on the EvaluationStrategy interface.

Expected Behavior

Remove the deprecated code.

Steps To Reproduce

No response

Version

4.x

Are you interested in contributing a solution yourself?

Yes

Anything else?

No response
@JervenBolleman JervenBolleman added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label May 21, 2023
@JervenBolleman JervenBolleman added this to the 5.0.0 milestone May 21, 2023
@JervenBolleman JervenBolleman self-assigned this May 21, 2023
JervenBolleman added a commit that referenced this issue May 21, 2023
@JervenBolleman
GH-4581 Remove limitedsize evaluation strategies.
7559682 
As well as supplier methods later better done with the collection
factory API.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
@JervenBolleman JervenBolleman mentioned this issue May 21, 2023
Merged
JervenBolleman added a commit that referenced this issue May 25, 2023
@JervenBolleman
GH-4581 make sure there is always a collection factory
b12ed0f 
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Apr 26, 2024
@JervenBolleman
GH-4581 Remove limitedsize evaluation strategies.
ed38e7c 
As well as supplier methods later better done with the collection
factory API.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Apr 26, 2024
@JervenBolleman
GH-4581 make sure there is always a collection factory
65bae43 
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Apr 26, 2024
@JervenBolleman
GH-4581 Make sure collection factories are used when we use a collection
4b30d24 
This allows to always be sure that we can fall back to disk if required.
Also allows optimized datastructures to be injected.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Apr 26, 2024
@JervenBolleman
GH-4581 Remove limitedsize evaluation strategies.
ff3b803 
As well as supplier methods later better done with the collection
factory API.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Apr 26, 2024
@JervenBolleman
GH-4581 Make sure collection factories are used when we use a collection
b241e9b 
This allows to always be sure that we can fall back to disk if required.
Also allows optimized datastructures to be injected.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue Apr 26, 2024
@JervenBolleman
GH-4581 Make sure collection factories are used when we use a collection
f8f7eee 
This allows to always be sure that we can fall back to disk if required.
Also allows optimized datastructures to be injected.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue May 31, 2024
@JervenBolleman
GH-4581 Remove limitedsize evaluation strategies.
b5cfb25 
As well as supplier methods later better done with the collection
factory API.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue May 31, 2024
@JervenBolleman
GH-4581 Make sure collection factories are used when we use a collection
95acc2a 
This allows to always be sure that we can fall back to disk if required.
Also allows optimized datastructures to be injected.

Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
JervenBolleman added a commit that referenced this issue May 31, 2024
@JervenBolleman
GH-4581 Remove limitedsize evaluation strategies.
a424d30 
As well as supplier methods later better done with the collection
factory API.
JervenBolleman added a commit that referenced this issue May 31, 2024
@JervenBolleman
GH-4581 Make sure collection factories are used when we use a collection
07e4174 
This allows to always be sure that we can fall back to disk if required.
Also allows optimized datastructures to be injected.
JervenBolleman added a commit that referenced this issue May 31, 2024
@JervenBolleman
GH-4581 Remove limitedsize evaluation strategies.
65ba065 
As well as supplier methods later better done with the collection
factory API.
JervenBolleman added a commit that referenced this issue May 31, 2024
@JervenBolleman
GH-4581 Make sure collection factories are used when we use a collection
a58ff06 
This allows to always be sure that we can fall back to disk if required.
Also allows optimized datastructures to be injected.
@hmottestad hmottestad added the M3 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JervenBolleman JervenBolleman

Labels
M3 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Gh 4581 remove jerven design mistakes eclipse-rdf4j/rdf4j
2 participants
@hmottestad @JervenBolleman