Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LMDB Store should cache IDs of common IRIs #5016

Closed
hmottestad opened this issue Jun 5, 2024 · 2 comments
Closed

LMDB Store should cache IDs of common IRIs #5016

hmottestad opened this issue Jun 5, 2024 · 2 comments
Assignees
@hmottestad
Labels
LMDB M3 ⏩ performance
Milestone
5.0.0

Comments

@hmottestad
Copy link
Contributor

Common IRIs, such as those in the w3c namespace, should have their IDs cache separately from other values since there are a limited number of these IRIs.
@hmottestad hmottestad self-assigned this Jun 5, 2024
@hmottestad hmottestad added this to the 5.0.0 milestone Jun 5, 2024
hmottestad added a commit that referenced this issue Jun 5, 2024
@hmottestad
GH-5016 introduce cache for common vocabulary in LMDB Store
e66a4e1
@kenwenzel
Copy link
Contributor

Does this have really an Impact?

@hmottestad hmottestad added the M3 label Jun 5, 2024
@hmottestad
Copy link
Contributor Author

Fairly minor in my benchmarks. If you think it's too complicated then we can still remove it before releasing 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
LMDB M3 ⏩ performance
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@kenwenzel @hmottestad