FedX does not correctly reduce federation members, when the query contains a FROM clause #5030
Assignees
Milestone
Comments
aschwarte10
added a commit
that referenced
this issue
Jun 14, 2024
FedX supports interpret the Dataset being defined on the query: if it is of type FedXDataset, the federation is reduced to the members defined by FedXDataset#getEndpoints(). This is a nice means to evaluate a query on a subset of the federation and is generally working fine. When the query contains a FROM clause, however, the externally passed Dataset is wrapped into a FallbackDataset (which internally keeps the FedXDataset as primary one. This change now inspects the FallbackDataset and unwraps it to reduce the members. Note that for execution still the "FallbackDataset" is used.
5 tasks
hmottestad
added a commit
that referenced
this issue
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
FedX supports interpret the Dataset being defined on the query: if it is of type
FedXDataset, the federation is reduced to the members defined byFedXDataset#getEndpoints().This is a nice means to evaluate a query on a subset of the federation and is generally working fine.
When the query contains a FROM clause, however, the externally passed
Datasetis wrapped into aFallbackDataset(which internally keeps the FedXDataset as primary one.Expected Behavior
The federation engine correctly respects an externally passed
FedXDatasetto reduce the federationSteps To Reproduce
See test case in the provided PR
Version
4.8.12
Are you interested in contributing a solution yourself?
Yes
Anything else?
Would like to see this merged still as part of 5.0
The text was updated successfully, but these errors were encountered: