Issues/#301 fix testsuite lock #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endLatch.countDown was only being run if exceptions were not thrown, which deadlocks tests that fail. Signed-off-by: Peter Ansell <p_ansell@yahoo.com>
Investigating this further Signed-off-by: Peter Ansell <p_ansell@yahoo.com>
This way the stacktraces, when they occur, should be visible in the logs to provide debugging. Signed-off-by: Peter Ansell <p_ansell@yahoo.com>
|
Hudson currently running on this PR. See https://hudson.eclipse.org/rdf4j/job/rdf4j-verify-pr/13/ |
|
Hudson build succeeded. Which tells us almost nothing :) |
|
If it helps, I haven't had this test lock up since putting those fixes in, although the test does still fail promptly when the underlying issue happens. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses GitHub issue: #301
Briefly describe the changes proposed in this PR: