GH-4431: Replace WireMock with MockServer #4439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
erikgb
force-pushed
the
GH-4431-wiremock-mockserver
branch
from
f049d5b
to
ecf16ba
Compare
|
The CI failure seems unrelated and probably a flake. Is there a way for regular users to trigger a re-run of failing workflows? |
erikgb
force-pushed
the
GH-4431-wiremock-mockserver
branch
from
ecf16ba
to
d12908b
Compare
This was referenced Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #4431
Briefly describe the changes proposed in this PR:
This PR migrates all use of WireMock in the codebase to MockServer. MockServer is built on Netty, and provides no-dependency shaded jars, which will ease upgrading Jetty (#4252), upgrade Java/Jakarta EE and migrate from Java EE to Jakarta EE (#3559).
The MockServer code is a bit more verbose, but fairly equivalent to WireMock. MockServer lacks the ability to load mocked response bodies from file, so in order to not change "everything" in this PR, I added small utility methods to adapt this missing feature. This can be changed/improved in a follow-up PR.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)