Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellEditorPopup: ignore key stroke when cell editor opens a form #1000

Open
wants to merge 1 commit into
base: releases/24.2
Choose a base branch
from
Open

CellEditorPopup: ignore key stroke when cell editor opens a form #1000

wants to merge 1 commit into from

Commits on May 8, 2024

  1. CellEditorPopup: ignore key stroke when cell editor opens a form 

    When a keystroke is triggered on a descendant of the cell editor field,
the cell editor popup should not be closed. This should also work if the
cell editor opens a form, which is not rendered within the cell editor
popup's $container.

Consider a cell editor that opens a form that also has an editable
column. If the inner cell editor is closed with Enter, the outer cell
editor popup should _not_ be completed automatically.

Instead of checking if the key stroke's scope target is part of the
$container, we also check the widget hierarchy of the scope target. If
it belongs to the cell editor, we don't trigger completeEdit().

378432
    @bschwarzent
    bschwarzent committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8424f16 View commit details
    Browse the repository at this point in the history