Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WidgetMap: support generics in objectTypes #30

Merged

Conversation

fschinkel
Copy link
Member

Parse typeArguments while converting an IdeaConstantValue to an ES6Class. In addition, unwrap JSParenthesizedExpression and (for IJ >= 2023.2) TypeScriptExpressionWithTypeArguments. Fix NPE while resolving the export target.

377491

@fschinkel fschinkel self-assigned this Apr 12, 2024
Copy link
Member

@mvilliger mvilliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much!
I also added one commit with an additional test case for nested complex type arguments.
On merge you can squash this commit into yours if you like.

@fschinkel fschinkel force-pushed the features/fschinkel/13.0/widget-map-generics branch from 8d09442 to 93c3265 Compare April 16, 2024 06:49
Parse typeArguments while converting an IdeaConstantValue to an
ES6Class. In addition, unwrap JSParenthesizedExpression and (for
IJ >= 2023.2) TypeScriptExpressionWithTypeArguments.
Fix NPE while resolving the export target.

377491
@fschinkel fschinkel force-pushed the features/fschinkel/13.0/widget-map-generics branch from 93c3265 to 6f9a971 Compare April 22, 2024 18:19
@fschinkel fschinkel merged commit b200273 into releases/13.0 Apr 22, 2024
2 checks passed
@fschinkel fschinkel deleted the features/fschinkel/13.0/widget-map-generics branch April 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants