Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a rich text edition widget #1346

Closed
pcdavid opened this issue Sep 12, 2022 · 0 comments · Fixed by #1384 or #1531
Closed

Add support for a rich text edition widget #1346

pcdavid opened this issue Sep 12, 2022 · 0 comments · Fixed by #1384 or #1531
Assignees
@pcdavid
Labels
difficulty: medium type: feature request
Milestone
2023.1.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Sep 12, 2022

It will behave similarly to the existing Textarea widget, except that the frontend will interpret the text value as Markdown and provide a WYSIWYG UI to edit it (and send the result as Markdown source).

It will be supported by the core APIs, the Views DSL and the Form Description Editor.
@pcdavid pcdavid self-assigned this Sep 12, 2022
pcdavid added a commit that referenced this issue Sep 14, 2022
@pcdavid
[DRAFT 1346] Add support for rich text widget in forms
24dc9c9 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 14, 2022
@pcdavid
[DRAFT 1346] Add richtext in view-based forms and form description ed…
b74bbec 
…itors

Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 16, 2022
@pcdavid
[DRAFT 1346] Add support for rich text widget in forms
dd20f41 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 16, 2022
@pcdavid
[DRAFT 1346] Add richtext in view-based forms and form description ed…
d4c3bb2 
…itors

Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 30, 2022
@pcdavid
[1346] Add support for rich text widget in forms
46779e7 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 30, 2022
@pcdavid
[1346] Add richtext in view-based forms and form description editors
a7f3a92 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 30, 2022
@pcdavid
[1346] Add support for rich text widget in forms
9d3ac3a 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Sep 30, 2022
@pcdavid
[1346] Add richtext in view-based forms and form description editors
d1d13fe 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Oct 3, 2022 that will close this issue
[1346] Add support for a "Rich Text" widget in forms #1384
Merged
39 tasks
@pcdavid pcdavid added this to the 2023.1.0 milestone Oct 3, 2022
pcdavid added a commit that referenced this issue Oct 4, 2022
@pcdavid
[1346] Add support for rich text widget in forms
69071a2 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 10, 2022
@pcdavid
[1346] Add support for rich text widget in forms
18933f5 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 18, 2022
@pcdavid
[1346] Add support for rich text widget in forms
34efd5e 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Oct 19, 2022
@pcdavid
[1346] Add support for rich text widget in forms
3c8c154 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 4, 2022
@pcdavid
[1346] Move to lexical 0.6.0
4bc3d1f 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 8, 2022
@pcdavid
[1346] Move the Save button to the right of the toolbar
6567452 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 8, 2022
@pcdavid
[1346] Fix placeholder placement and styling
ab3e35a 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 8, 2022
@pcdavid
[1346] Disable the save icon when in pristine state
ff8a8bb 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 18, 2022
@pcdavid
[1346] Add support for rich text widget in forms
cbee15f 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 18, 2022
@pcdavid
[1346] Add support for rich text widget in forms
ddcec57 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 18, 2022
@pcdavid
[1346] Add support for rich text widget in forms
f8ae541 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 21, 2022
@pcdavid @AxelRICHARD
[1346] Add support for rich text widget in forms
2e91ddb 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 21, 2022
@pcdavid @AxelRICHARD
[1346] Add support for rich text widget in forms
97c48a2 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 21, 2022
@pcdavid @AxelRICHARD
[1346] Add support for rich text widget in forms
8ce4e52 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
pcdavid added a commit that referenced this issue Nov 29, 2022
@pcdavid
[1346] Change the Save icon for rich text editor
5670d98 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Nov 29, 2022
Merged
39 tasks
AxelRICHARD pushed a commit that referenced this issue Nov 29, 2022
@pcdavid @AxelRICHARD
[1346] Change the Save icon for rich text editor
9cdd7b6 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Nov 29, 2022
Merged
39 tasks
pcdavid added a commit that referenced this issue Nov 29, 2022
@pcdavid
[1346] Auto-save on blur/focus lost
2106220 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 1, 2022
@pcdavid
[1346] Auto-save on blur/focus lost
802d7af 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 2, 2022
@pcdavid
[1346] Auto-save on blur/focus lost
4dc9ddf 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 6, 2022
@pcdavid
[1346] Remove support for underline in the toolbar
371294c 
The underling style is not actually supported by Markdown and Lexical

Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Dec 6, 2022
@pcdavid @AxelRICHARD
[1346] Auto-save on blur/focus lost
d177139 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Dec 6, 2022
@pcdavid @AxelRICHARD
[1346] Remove support for underline in the toolbar
8d5f8bb 
The underling style is not actually supported by Markdown and Lexical

Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Dec 12, 2022
Merged
39 tasks
pcdavid added a commit that referenced this issue Dec 12, 2022
@pcdavid
[1346] Avoid unnecessary invocations of the editRichText mutation
9d17ea5 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Dec 12, 2022
@pcdavid @AxelRICHARD
[1346] Avoid unnecessary invocations of the editRichText mutation
7800fac 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 15, 2022
@pcdavid
[1346] Create stable ids for Group instances
e337d25 
This avoids unnecessary re-renders on the front which would consider
each new version of the Form to contain completely new Group
instances.

Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Dec 15, 2022
@pcdavid
[1346] Do not let lexical take the focus on update
d06b354 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Dec 16, 2022 that will close this issue
Fix the Rich Text widget focus stealing #1531
Merged
sbegaudeau pushed a commit that referenced this issue Dec 16, 2022
@pcdavid @sbegaudeau
[1346] Create stable ids for Group instances
f0bb7ea 
This avoids unnecessary re-renders on the front which would consider
each new version of the Form to contain completely new Group
instances.

Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 16, 2022
@pcdavid @sbegaudeau
[1346] Do not let lexical take the focus on update
c02cf1f 
Bug: #1346
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium type: feature request
Projects
None yet
Milestone
2023.1.0
1 participant
@pcdavid