[1346] Add support for a "Rich Text" widget in forms #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcdavid
force-pushed
the
pcd/enh/rich-text-editor
branch
2 times, most recently
from
69071a2
to
18933f5
Compare
pcdavid
changed the title
pcdavid
changed the title
AxelRICHARD
requested changes
Oct 10, 2022
...rontend/sirius-components-formdescriptioneditors/src/FormDescriptionEditorRepresentation.tsx
Outdated
Show resolved
Hide resolved
...mdescriptioneditors/frontend/sirius-components-formdescriptioneditors/src/RichTextWidget.tsx
Outdated
Show resolved
Hide resolved
packages/view/backend/sirius-components-view-edit/plugin.properties
Outdated
Show resolved
Hide resolved
pcdavid
force-pushed
the
pcd/enh/rich-text-editor
branch
2 times, most recently
from
34efd5e
to
3c8c154
Compare
AxelRICHARD
requested changes
Nov 7, 2022
| @@ -0,0 +1,43 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2020 Obeo. | |||
| <div className={classes.editorContainer}> | ||
| <RichTextPlugin | ||
| contentEditable={<ContentEditable onFocus={onFocus} readOnly={readOnly} />} | ||
| placeholder={<div className={classes.editorPlaceholder}>{placeholder}</div>} |
There was a problem hiding this comment.
The placeholder has been put in a weird position, under text text area:
Is it possible to put on the text area?
AxelRICHARD
requested changes
Nov 7, 2022
| @@ -821,6 +821,29 @@ public Adapter createTextAreaDescriptionAdapter() { | |||
| return this.textAreaDescriptionItemProvider; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Please add new RichTextDescription in org.eclipse.sirius.components.view.provider.FormDescriptionItemProvider.collectNewChildDescriptors(Collection, Object)
pcdavid
force-pushed
the
pcd/enh/rich-text-editor
branch
3 times, most recently
from
ddcec57
to
f8ae541
Compare
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD
force-pushed
the
pcd/enh/rich-text-editor
branch
from
f8ae541
to
2e91ddb
Compare
AxelRICHARD
approved these changes
Nov 21, 2022
Bug: #1346 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr> Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD
force-pushed
the
pcd/enh/rich-text-editor
branch
from
2e91ddb
to
97c48a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request