Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly created view on the diagram background do not appear at the drop location #1720

Closed
pcdavid opened this issue Feb 16, 2023 · 1 comment · Fixed by #1750
Closed

Newly created view on the diagram background do not appear at the drop location #1720

pcdavid opened this issue Feb 16, 2023 · 1 comment · Fixed by #1750
Labels
difficulty: medium package: diagrams type: bug
Milestone
2023.3.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Feb 16, 2023

Not even completely inside the visible area:

simplescreenrecorder-2023-02-15_17.02.05.mp4

It seems that views created inside a container are correctly created at the drop location.
@pcdavid
Copy link
Member Author

pcdavid commented Feb 20, 2023

Caused by RectangleIncrementalLayoutEngine.processChildrenAreaLayoutResult(ChildrenAreaLaidOutData, NodeContext) (and the other *IncrementalLayoutEngine) which modify the position of the current node to something different from Position.UNDEFINED. This makes NodePositionProvider.getPositionFromSinglePositionEvent() a no-op as it tests for Position.UNDEFINED before consuming the SinglePositionEvent's coordinates.

@pcdavid pcdavid added this to the 2023.3.0 milestone Feb 20, 2023
pcdavid added a commit that referenced this issue Feb 22, 2023
@pcdavid
[1720] Fix drop position handling
63c060f 
Bug: #1720
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Feb 22, 2023
Merged
39 tasks
pcdavid added a commit that referenced this issue Feb 22, 2023
@pcdavid
[1720] Fix drop position handling
1ea31c6 
Bug: #1720
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Feb 22, 2023 that will close this issue
[1720] Fix drop position handling #1750
Merged
39 tasks
sbegaudeau pushed a commit that referenced this issue Feb 23, 2023
@pcdavid @sbegaudeau
[1720] Fix drop position handling
8c64bd3 
Bug: #1720
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2023.3.0
Development

Successfully merging a pull request may close this issue.

[1720] Fix drop position handling eclipse-sirius/sirius-web
1 participant
@pcdavid