Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All tree items are editable #2222

Closed
frouene opened this issue Aug 3, 2023 · 0 comments · Fixed by #2223
Closed

All tree items are editable #2222

frouene opened this issue Aug 3, 2023 · 0 comments · Fixed by #2223
Labels
difficulty: medium package: trees type: bug
Milestone
2023.10.0

Comments

@frouene
Copy link
Contributor

frouene commented Aug 3, 2023

The control for defining whether an explorer element is editable (rename submenu) is always displayed, even for elements that have no label.

image

When editing, the backend returns a Failure with empty text, which causes the toast system to crash.
frouene added a commit that referenced this issue Aug 3, 2023
@frouene
[2222] Fix error during not editable tree item renaming
942c517 
Bug: #2222
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene mentioned this issue Aug 3, 2023
Merged
39 tasks
@frouene frouene linked a pull request Aug 3, 2023 that will close this issue
[2222] Fix error during not editable tree item renaming #2223
Merged
39 tasks
frouene added a commit that referenced this issue Aug 3, 2023
@frouene
[2222] Fix error during not editable tree item renaming
4a40b80 
Bug: #2222
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@sbegaudeau sbegaudeau added this to the 2023.10.0 milestone Aug 10, 2023
frouene added a commit that referenced this issue Aug 11, 2023
@frouene
[2222] Fix error during not editable tree item renaming
eb9eaf2 
Bug: #2222
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Aug 23, 2023
@frouene @sbegaudeau
[2222] Fix error during not editable tree item renaming
43d81a9 
Bug: #2222
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium package: trees type: bug
Projects
None yet
Milestone
2023.10.0
Development

Successfully merging a pull request may close this issue.

[2222] Fix error during not editable tree item renaming eclipse-sirius/sirius-web
2 participants
@sbegaudeau @frouene