-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preconditions from the tools are not respected #779
Comments
Thanks for the detailed report. This is a known limitation at the moment. |
This sounds like a logical solution 👍 I understand it will take some time to implement and may not be a priority at the moment. Is there any way I can replicate this functionality (disallowing edges to be created under certain conditions) in Sirius Web? |
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Also rename associated mutation and results in DiagramWebSocketContainer Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Temporary remove the computation of synchronization state in ContextualPalette frontend component. Will be computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Do not handle CreateEdgeTool preconditions (start & complete) for now. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Temporary remove the computation of synchronization state in ContextualPalette frontend component. Will be computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Do not handle EdgeCreationTool preconditions (start & complete) yet. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Also rename associated mutation and results in DiagramWebSocketContainer Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Temporary remove the computation of synchronization state in ContextualPalette frontend component. Will be computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Fix warning message in console: 'Warning: Each child in a list should have a unique "key" prop.' Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
This method is not used anymore. This part is computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
-Add new DataFetcher for toolSections -Support new API IIdentifierProvider#findVsmElementId Bug: eclipse-sirius/sirius-web#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Also rename associated mutation and results in DiagramWebSocketContainer Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Temporary remove the computation of synchronization state in ContextualPalette frontend component. Will be computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Do not handle EdgeCreationTool preconditions (start & complete) yet. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Fix warning message in console: 'Warning: Each child in a list should have a unique "key" prop.' Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
This method is not used anymore. This part is computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Also rename associated mutation and results in DiagramWebSocketContainer Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Temporary remove the computation of synchronization state in ContextualPalette frontend component. Will be computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Implementations must provide the tool sections (and associated tools) for a given diagram element. Add a first implementation of this new interface for the compatibility layer. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Do not handle EdgeCreationTool preconditions (start & complete) yet. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Fix warning message in console: 'Warning: Each child in a list should have a unique "key" prop.' Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
This method is not used anymore. This part is computed by the backend. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
…ram element A new API based on the IToolSectionsProvider is now available in order to let specifiers define which tools are available dynamically when the contextual palette is requested by the frontend. An implementation has been provided for the Sirius RCP compatibility layer which uses the various preconditions which can be defined in an odesign file in order to compute the tool sections and tools which should be available for a specific diagram element. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
…ram element A new API based on the IToolSectionsProvider is now available in order to let specifiers define which tools are available dynamically when the contextual palette is requested by the frontend. An implementation has been provided for the Sirius RCP compatibility layer which uses the various preconditions which can be defined in an odesign file in order to compute the tool sections and tools which should be available for a specific diagram element. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
…ram element A new API based on the IToolSectionsProvider is now available in order to let specifiers define which tools are available dynamically when the contextual palette is requested by the frontend. An implementation has been provided for the Sirius RCP compatibility layer which uses the various preconditions which can be defined in an odesign file in order to compute the tool sections and tools which should be available for a specific diagram element. Bug: eclipse-sirius#779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
…ram element A new API based on the IToolSectionsProvider is now available in order to let specifiers define which tools are available dynamically when the contextual palette is requested by the frontend. An implementation has been provided for the Sirius RCP compatibility layer which uses the various preconditions which can be defined in an odesign file in order to compute the tool sections and tools which should be available for a specific diagram element. Bug: #779 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Screenshots
Edge Creation forbidden in Sirius Desktop, as expected (due to preconditions set to
aql:false
):Peek.2021-10-17.16-46.mp4
It is allowed in Sirius Web (neither Start nor Complete conditions are checked):
Peek.2021-10-17.16-48.mp4
Steps to reproduce
Add Conneciton Start Precondition or Connection Complete Precondition to an Edge Creation Tool:
Expected behavior
false
)false
Actual behavior
Despite preconditions being
false
, the edge can be freely created, as if they were not taken into account.The text was updated successfully, but these errors were encountered: