Improve DomainConverter #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pcdavid
commented
Jul 16, 2021
•
pcdavid
commented
- [cleanup] Simplify domain inheritance conversion code
- [cleanup] Refactor domain conversion code
- [cleanup] Refactor EditingContextEPackageService
- [cleanup] Log a warning when multiple domains/packages have the same nsURI
- [fix] Ignore documents which could not be loaded properly
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
- Keep the feature flag out of the DomainConverter itself so it stays a simple, context-free converter. - Prevent dynamic domain definitions to override core EPackages like Ecore itself. Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Also add support for multiple Domain definitions inside a single document (previously we only took the first one into account). Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
…nsURI Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
When a dynamic instance could not be loaded anymore (typically because it's domain definition has been removed or has changed in an incompatible way), we exposed an unusable document in the explorer, with a raw UUID as its name. Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.