[376] Remove code now accessible as APIs in GEF #377
+1,111
−406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only updates the data used by SnapAllShapesTest without any change (except the migration).
The test org.eclipse.sirius.tests.swtbot.SnapAllShapesTest.testMoveBorderNodeOnNodeInContainer() has been updated. It wrongly used the same border nodes as "testMoveBorderNodeOnBorderNode()". This case has been detected because the new test class MoveAllShapesWithArrowKeysTest is inspired by this one.
This commit changes the CheckBoundsCondition to also be able to consider the HandleBounds figure and the scrollbars. A rounding problem has been detected in GraphicalHelper and fixed during these tests. Bug: #359
This commit disables the snap to the perpendicular axis of the arrow direction. Indeed, if the user moves a node in the left direction, for example, it doesn't want to see its node moves up or down too. The tests have also been adapted. Bug: #359
This commit removes the code duplicated from GEF as it is now available as API in GEF (through issue eclipse/gef-classic#426). Bug: #376
lredor
force-pushed
the
bug/lre/359-moveFromKeyboard
branch
2 times, most recently
from
6f99363
to
3ed7653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the code duplicated from GEF as it is now available as API in GEF (through issue
eclipse/gef-classic#426).
Bug: #376