Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[394] Add variables "diagram" and "view" during direct edit execution #395

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lredor
Copy link
Contributor

@lredor lredor commented May 17, 2024

For a direct edit tool, the variables "diagram" and "view" were available during the evaluation of inputLabelExpression but they were no longer available during the execution of the tool. This commit solves this problem by setting these variables just before setting of edit mask variables.

By the way, all the edit mask variables are never cleaned. This is not the goal of this issue.

Bug: #394

For a direct edit tool, the variables "diagram" and "view" were
available during the evaluation of `inputLabelExpression` but they were
no longer available during the execution of the tool.
This commit solves this problem by setting these variables just before
setting of edit mask variables.

By the way, all the edit mask variables are never cleaned. This is not
the goal of this issue.

Bug: #394
This commit only migrates the test data that will be used in the new
test.

Bug: #394
This commit updates the test data to:
- Add a new class named "ClassA",
- Change the direct edit tool on classes to have a specific behavior
using variables "view" and "diagram" when the name of the class is
"ClassA"?

Bug: #394
During analysis of issue #394 [1], it was observed that the variables
created during the execution of a direct edit tool ware not cleaned.
This commit fixes this problem and adds corresponding automatic tests.

[1]  #394
@lredor lredor force-pushed the lre/bug/394-addVariablesForDirectEditTool branch from 1a7c505 to e5ed1f2 Compare May 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DirectEditLabel does not provide 'view' variable during operation execution
1 participant