[542678] specification for bundle image extension point #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of a specification concerning the improvement to the bundle image provided shape extension point bug: 542678 Signed-off-by: Steve Monnier <steve.monnier@obeo.fr>
lredor
requested changes
Dec 12, 2018
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Show resolved
Hide resolved
Addition of a specification concerning the improvement to the bundle image provided shape extension point bug: 542678 Signed-off-by: Steve Monnier <steve.monnier@obeo.fr>
lredor
requested changes
Dec 13, 2018
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
| @@ -41,7 +41,7 @@ This feature uses the existing API and does not need new API or API changes. | |||
|
|
|||
| h3. User Interface Changes | |||
|
|
|||
| The extension point tags _colorAttribute_, _borderColorAttribute_ and __borderSizeAttribute__ will now provide a sub attribute (not mandatory). | |||
| The extension point tags @colorAttribute@, @borderColorAttribute@ and @borderSizeAttribute@ will now provide a sub attribute (not mandatory). | |||
There was a problem hiding this comment.
Maybe the format of the extension point will be different.
<image imagePath="myPath" label="myLabel"> <backgroundcolor colorIdentifier="stop8224-2" colorAttribute="style"/> ...
instead of
<image imagePath="/org.eclipse.sirius.tests.swtbot/images/donut.svg" label="Donut"> <colorIdentifier colorIdentifier="stop8224-2"> </colorIdentifier> <colorAttribute colorAttribute="style"> </colorAttribute>...
There was a problem hiding this comment.
Limitation identified in "Implementation choices and tradeoffs"
| We will need to test the color, border color and border size with two new sample: | ||
| Tests on the older version of the extension point need to be still working after this enhancement. | ||
|
|
||
| For the new extension point, we will need to test the color, border color and border size with two new sample: |
There was a problem hiding this comment.
with two new sample
with 3 new samples
There was a problem hiding this comment.
I just have two new samples:
- one with multi-valued attributes different than from donut.svg
- one with single-valued attributes
There was a problem hiding this comment.
After some toughts, I will also had the donut.svg sample. It will not make a difference with the other multi-valued sample...but it will draw a connection between the old extension point and the new one.
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Show resolved
Hide resolved
Update the specification concerning the improvement to the bundle image provided shape extension point with the different remarks. bug: 542678 Signed-off-by: Steve Monnier <steve.monnier@obeo.fr>
lredor
approved these changes
Dec 14, 2018
lredor
reviewed
Dec 14, 2018
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
...posal/542678_improve_bundle_image_provided_shape/improve_bundle_image_provided_shape.textile
Outdated
Show resolved
Hide resolved
Improve the specification concerning the improvement to the bundle image provided shape extension point with the different remarks. bug: 542678 Signed-off-by: Steve Monnier <steve.monnier@obeo.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a specification concerning the improvement to the bundle
image provided shape extension point
bug: 542678
Signed-off-by: Steve Monnier steve.monnier@obeo.fr