Skip to content

Commit

Permalink
[1580] Border node can be moved manually
Browse files Browse the repository at this point in the history
Bug: #1580
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
  • Loading branch information
gcoutable committed Jan 13, 2023
1 parent 060532e commit 033fe29
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.adoc
Expand Up @@ -14,6 +14,10 @@

- https://github.com/eclipse-sirius/sirius-components/issues/1377[#1377] [core] Switch to Java 17

=== Bug fixes

https://github.com/eclipse-sirius/sirius-components/issues/1580[#1580] [diagram] Border nodes do not return to their previous position after they have been moved manually

=== New Features

- https://github.com/eclipse-sirius/sirius-components/issues/1567[#1567] [project] Add support for project templates
Expand Down
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2022 Obeo.
* Copyright (c) 2022, 2023 Obeo.
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v2.0
* which accompanies this distribution, and is available at
Expand All @@ -14,7 +14,7 @@ import { decorate, inject } from 'inversify';
import { CommandExecutionContext, SModelElement, SModelRoot, TYPES } from 'sprotty';
import { generateRequestId, RequestAction, ResponseAction } from 'sprotty-protocol';
import { ModelRequestCommand } from 'sprotty/lib/base/commands/request-command';
import { Edge, Node } from '../Diagram.types';
import { BorderNode, Edge, Node } from '../Diagram.types';

export interface IsSiriusModelElementAction extends RequestAction<IsSiriusModelElementResult> {
kind: typeof IsSiriusModelElementAction.KIND;
Expand Down Expand Up @@ -71,5 +71,5 @@ export class IsSiriusModelElementCommand extends ModelRequestCommand {
decorate(inject(TYPES.Action) as ParameterDecorator, IsSiriusModelElementCommand, 0);

export const isSiriusModelElement = (element: SModelElement): boolean => {
return element instanceof Node || element instanceof Edge;
return element instanceof Node || element instanceof BorderNode || element instanceof Edge;
};

0 comments on commit 033fe29

Please sign in to comment.