[2778] Authorize empty string for direct edit

Bug: #2778 Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
eclipse-sirius · Dec 13, 2023 · 2fcf59d · 2fcf59d
1 parent a25cbc6
commit 2fcf59d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 28 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -63,6 +63,7 @@ info: {
 === Bug fixes
 
 - https://github.com/eclipse-sirius/sirius-web/issues/2812[#2812] [trees] Fix an issue that prevents icon to be displayed in treeNodes.
+- https://github.com/eclipse-sirius/sirius-web/issues/2778[#2778] [diagram] Authorize empty string for direct edit.
 
 === New Features
 

diff --git a/.../sirius-components-diagrams-reactflow/src/renderer/direct-edit/DiagramDirectEditInput.tsx b/.../sirius-components-diagrams-reactflow/src/renderer/direct-edit/DiagramDirectEditInput.tsx
@@ -141,20 +141,17 @@ export const DiagramDirectEditInput = ({ labelId, editingKey, onClose, transform
   }, [initialLabelItemError, initialLabelItemData]);
 
   const doRename = () => {
-    const isNameValid = state.newLabel.length >= 1;
-    if (isNameValid) {
-      renameElement({
-        variables: {
-          input: {
-            id: crypto.randomUUID(),
-            editingContextId: editingContextId,
-            representationId: diagramId,
-            labelId: labelId,
-            newText: state.newLabel,
-          },
+    renameElement({
+      variables: {
+        input: {
+          id: crypto.randomUUID(),
+          editingContextId: editingContextId,
+          representationId: diagramId,
+          labelId: labelId,
+          newText: state.newLabel,
         },
-      });
-    }
+      },
+    });
   };
 
   const handleChange = (event: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {

diff --git a/packages/trees/frontend/sirius-components-trees/src/treeitems/TreeItemDirectEditInput.tsx b/packages/trees/frontend/sirius-components-trees/src/treeitems/TreeItemDirectEditInput.tsx
@@ -123,22 +123,17 @@ export const TreeItemDirectEditInput = ({
   }, [renameTreeItemData, renameTreeItemError]);
 
   const doRename = () => {
-    const isNameValid = state.newLabel.length >= 1;
-    if (isNameValid) {
-      renameTreeItem({
-        variables: {
-          input: {
-            id: crypto.randomUUID(),
-            editingContextId: editingContextId,
-            representationId: treeId,
-            treeItemId: treeItemId,
-            newLabel: state.newLabel,
-          },
+    renameTreeItem({
+      variables: {
+        input: {
+          id: crypto.randomUUID(),
+          editingContextId: editingContextId,
+          representationId: treeId,
+          treeItemId: treeItemId,
+          newLabel: state.newLabel,
         },
-      });
-    } else {
-      onClose();
-    }
+      },
+    });
   };
 
   const handleChange = (event) => {