Skip to content

Commit

Permalink
[2550] Hide diagram element palette on viewport or zoom change
Browse files Browse the repository at this point in the history
Bug: #2550
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
  • Loading branch information
mcharfadi committed Nov 9, 2023
1 parent 7e825b9 commit 794a788
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Expand Up @@ -72,6 +72,7 @@ Note that double-clicking no longer triggers a direct edit.
- https://github.com/eclipse-sirius/sirius-web/issues/2532[#2532] [diagram] Fix the limitation on borders that prevent movement on all sides of their node parent.
- https://github.com/eclipse-sirius/sirius-web/issues/2543[#2543] [diagram] Prevent list items being moved to inconsistent positions
- https://github.com/eclipse-sirius/sirius-web/issues/2500[#2500] [diagram] Selecting an element in the explorer now correctly selects and focuses on the corresponding edge on the current diagram if there is one.
- https://github.com/eclipse-sirius/sirius-web/issues/2550[#2550] [diagram] Palette is now hidden on viewport or zoom change.

=== New Features

Expand Down
Expand Up @@ -32,14 +32,14 @@ import {
useStoreApi,
} from 'reactflow';

import { useBorderChange } from './border/useBorderChange';
import { NodeTypeContext } from '../contexts/NodeContext';
import { NodeTypeContextValue } from '../contexts/NodeContext.types';
import { convertDiagram } from '../converter/convertDiagram';
import { Diagram, DiagramRendererProps, DiagramRendererState, EdgeData, NodeData } from './DiagramRenderer.types';
import { useBorderChange } from './border/useBorderChange';
import { ConnectorContextualMenu } from './connector/ConnectorContextualMenu';
import { useConnector } from './connector/useConnector';
import { useDiagramDelete } from './delete/useDiagramDelete';
import { Diagram, DiagramRendererProps, DiagramRendererState, EdgeData, NodeData } from './DiagramRenderer.types';
import { useDiagramDirectEdit } from './direct-edit/useDiagramDirectEdit';
import { useDrop } from './drop/useDrop';
import { useDropNode } from './dropNode/useDropNode';
Expand Down Expand Up @@ -75,7 +75,7 @@ export const DiagramRenderer = ({ diagramRefreshedEventPayload, selection, setSe

const { layout, resetReferencePosition } = useLayout();
const { onDiagramBackgroundClick, hideDiagramPalette } = useDiagramPalette();
const { onDiagramElementClick } = useDiagramElementPalette();
const { onDiagramElementClick, hideDiagramElementPalette } = useDiagramElementPalette();

const { onConnect, onConnectStart, onConnectEnd } = useConnector();
const { reconnectEdge } = useReconnectEdge();
Expand Down Expand Up @@ -295,7 +295,10 @@ export const DiagramRenderer = ({ diagramRefreshedEventPayload, selection, setSe
onPaneClick={handlePaneClick}
onEdgeClick={onDiagramElementClick}
onNodeClick={onDiagramElementClick}
onMove={() => hideDiagramPalette()}
onMove={() => {
hideDiagramPalette();
hideDiagramElementPalette();
}}
onDrop={onDrop}
onDragOver={onDragOver}
onNodeDrag={onNodeDrag}
Expand Down

0 comments on commit 794a788

Please sign in to comment.