Skip to content

Commit

Permalink
[2195] Set border color to None now set the color to none
Browse files Browse the repository at this point in the history
Instead of set the color to a default color

Bug: #2195
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
  • Loading branch information
AxelRICHARD committed Sep 4, 2023
1 parent 7440877 commit f81b5ee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.adoc
Expand Up @@ -59,6 +59,7 @@ A suitable implementation is to get the id of the `self` object using `IObjectSe
- https://github.com/eclipse-sirius/sirius-components/issues/2222[#2222] [tree] Fix an issue where all the tree items where editable, even for elements that have no label.
- https://github.com/eclipse-sirius/sirius-web/issues/2245[#2245] [sirius-web] Fix an issue when triggering expandAll on models with multiple root objects.
- https://github.com/eclipse-sirius/sirius-web/issues/2333[#2333] [diagram] Fix a warning console when opening a palette on a diagram.
- https://github.com/eclipse-sirius/sirius-web/issues/2195[#2195] [view] Fix an issue where a border color set to _None_ would set the color to a default color, not none.

=== New Features

Expand All @@ -68,7 +69,7 @@ A suitable implementation is to get the id of the `self` object using `IObjectSe
- https://github.com/eclipse-sirius/sirius-web/issues/2253[#2253] [diagram] Add the possibility of organizing palette tools into sections
- https://github.com/eclipse-sirius/sirius-web/issues/2236[#2236] [forms] It is now possible to use `For` and `If` constructs inside the definition of Form (currently only inside _Groups_ and _Flexbox containers_).
Both constructs are commonly combined together, with e.g. _For_ iterating on the different features of the current semantic element and several _If_ inside the loop to decide which concrete widget(s) to instantiate depending on the feature's type.
They can however also be used independently (e.g. a single _If_ ouside of a _For_ to make the presence of a widget conditional) and combined in arbitrary ways (e.g. nested loops or conditionals).
They can however also be used independently (e.g. a single _If_ outside of a _For_ to make the presence of a widget conditional) and combined in arbitrary ways (e.g. nested loops or conditionals).
Note that this first version has a known limitation: _FormDescriptions_ which use _For_ or _If_ elements can not be reliably edited using the _Form Description Editor_.
This will be fixed in the next version.

Expand Down
Expand Up @@ -152,7 +152,7 @@ public INodeStyle createNodeStyle(NodeStyleDescription nodeStyle, Optional<Strin
.filter(FixedColor.class::isInstance)
.map(FixedColor.class::cast)
.map(FixedColor::getValue)
.orElse(DEFAULT_COLOR))
.orElse(""))
.borderSize(nodeStyle.getBorderSize())
.borderStyle(LineStyle.valueOf(nodeStyle.getBorderLineStyle().getLiteral()))
.borderRadius(nodeStyle.getBorderRadius())
Expand Down Expand Up @@ -181,7 +181,7 @@ public INodeStyle createNodeStyle(NodeStyleDescription nodeStyle, Optional<Strin
.filter(FixedColor.class::isInstance)
.map(FixedColor.class::cast)
.map(FixedColor::getValue)
.orElse(DEFAULT_COLOR))
.orElse(""))
.borderSize(nodeStyle.getBorderSize())
.borderStyle(LineStyle.valueOf(nodeStyle.getBorderLineStyle().getLiteral()))
.borderRadius(nodeStyle.getBorderRadius())
Expand Down

0 comments on commit f81b5ee

Please sign in to comment.