Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the IWidgetDescriptor API #2064

Closed
pcdavid opened this issue Jun 14, 2023 · 1 comment
Closed

Improve the IWidgetDescriptor API #2064

pcdavid opened this issue Jun 14, 2023 · 1 comment
Assignees
@pcdavid
Labels
difficulty: medium package: forms type: code quality
Milestone
2023.8.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Jun 14, 2023

In #1914 a new IWidgetDescriptor API was introduced on the backend to allow the the Form redering to handle custom widgets not defined in the core.
The shape of the API was modeled "naively" to match how FormInstancePropsValidator, FormElementFactory & co. handle the core component, but it lacks flexibility.
In particular it assumes that a given component type/class can only produce a single type of element (and a single type of corresponding props).
@pcdavid pcdavid added this to the 2023.8.0 milestone Jun 14, 2023
@pcdavid pcdavid mentioned this issue Jun 14, 2023
Closed
pcdavid added a commit that referenced this issue Jun 14, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
5dbfdad 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid self-assigned this Jun 14, 2023
@pcdavid pcdavid linked a pull request Jun 14, 2023 that will close this issue
[2064] Improve IWidgetDescriptor API #2065
Closed
pcdavid added a commit that referenced this issue Jun 14, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
d913c97 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 15, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
e01ca89 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 16, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
52f4bda 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 16, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
8056bcf 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 20, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
6acd89f 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 20, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
4763275 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 20, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
261bdef 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 21, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
92df86e 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jun 23, 2023
@pcdavid
[2064] Improve IWidgetDescriptor API
b03cfdb 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Jun 23, 2023
@pcdavid @AxelRICHARD
[2064] Improve IWidgetDescriptor API
53916cd 
Bug: #2064
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid
Copy link
Member Author

pcdavid commented Jun 26, 2023

Fixed by 53916cd

@pcdavid pcdavid closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: forms type: code quality
Projects
None yet
Milestone
2023.8.0
Development

Successfully merging a pull request may close this issue.

[2064] Improve IWidgetDescriptor API eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau